-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload failed #112390
Comments
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ dda421d56ace4a4c04604d0b99c3227f3948f45e: Fatal error:
Stack:
Log preceding fatal error
Parameters: Same failure on other branches
|
@chrisseto can you check if this might be related to any new changes added to the schema change workload? |
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 26fbd322059f7e42084648e3cba99e697958f1b8:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ ff055942cbd72f699764a4c7d185af79d878e036:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 877e24c91113ef9fe67fae44511f9f77cf2650c2:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 877e24c91113ef9fe67fae44511f9f77cf2650c2:
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 1e5be546f219b64b171cb1f39985706b5809d79b: Fatal error:
Stack:
Log preceding fatal error
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 1e5be546f219b64b171cb1f39985706b5809d79b: Fatal error:
Stack:
Log preceding fatal error
Parameters: Same failure on other branches
|
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 45bfb4bf0c88330c273363039b8063d6ed516da4: Fatal error:
Stack:
Log preceding fatal error
Parameters: Same failure on other branches
|
The bug here is typedesc schema change coupled with a DROP operation colliding together, which leads to the legacy job hitting and getting hung on:
|
Previously, the declarative schema changer only waited for legacy schema changer mutations/jobs on relations and did not correctly account for type schema changes. As a result, it was possible to drop a type concurrently while a schema change was trying to mutate a type, which could lead to type change jobs hanging. To address this, this patch causes declarative schema changes to wait for type modifications. Fixes: cockroachdb#112390, cockroachdb#111540 Release note (bug fix): ALTER TYPE could get stuck if DROP TYPE was executed concurrently.
113639: sql/schemachanger: prevent concurrent type desc changes r=fqazi a=fqazi Previously, the declarative schema changer only waited for legacy schema changer mutations/jobs on relations and did not correctly account for type schema changes. As a result, it was possible to drop a type concurrently while a schema change was trying to mutate a type, which could lead to type change jobs hanging. To address this, this patch causes declarative schema changes to wait for type modifications. Fixes: #112390, #111540 Release note (bug fix): ALTER TYPE could get stuck if DROP TYPE was executed concurrently. Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Previously, the declarative schema changer only waited for legacy schema changer mutations/jobs on relations and did not correctly account for type schema changes. As a result, it was possible to drop a type concurrently while a schema change was trying to mutate a type, which could lead to type change jobs hanging. To address this, this patch causes declarative schema changes to wait for type modifications. Fixes: #112390, #111540 Release note (bug fix): ALTER TYPE could get stuck if DROP TYPE was executed concurrently.
pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed with artifacts on release-23.2 @ 87a94f6ac59d4e01c822bb2128db858176600dd6:
Parameters:
TAGS=bazel,gss,deadlock
,stress=true
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-32392
The text was updated successfully, but these errors were encountered: