Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: acceptance/version-upgrade failed #116425

Closed
cockroach-teamcity opened this issue Dec 14, 2023 · 1 comment · Fixed by #116587
Closed

roachtest: acceptance/version-upgrade failed #116425

cockroach-teamcity opened this issue Dec 14, 2023 · 1 comment · Fixed by #116587
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 14, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.acceptance/version-upgrade failed with artifacts on master @ d7d6901db6e322fbbb57ce2407e9e1ce42d9360c:

(mixedversion.go:539).Run: mixed-version test failure while running step 14 (run "test schema change step"): full command output in run_064010.411166606_n1_v22217workload-run-s.log: COMMAND_PROBLEM: exit status 1
test artifacts and logs in: /artifacts/acceptance/version-upgrade/run_1

Parameters:

  • ROACHTEST_arch=amd64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_metamorphicBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

/cc @cockroachdb/test-eng

This test on roachdash | Improve this report!

Jira issue: CRDB-34616
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-testeng TestEng Team labels Dec 14, 2023
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Dec 14, 2023
@renatolabs renatolabs removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Dec 14, 2023
@renatolabs
Copy link
Contributor

Same issue as #116304. @cockroachdb/sql-foundations please see my comment on that issue.

@renatolabs renatolabs mentioned this issue Dec 15, 2023
Merged
craig bot pushed a commit that referenced this issue Dec 15, 2023
@sumeerbhola @rafiss
@msbutler @renatolabs
Merge #116544 #116549 #116567 #116580 #116587
5380e08 
116544: storage: add single delete callbacks to crash, or increment metrics r=jbowens a=sumeerbhola

Handlers are added for SingleDeleteInvariantViolationCallback and IneffectualSingleDeleteCallback options in Pebble. By default, they crash the process. If crashing is turned off, they increment metrics, storage.single-delete.invariant-violation and
storage.single-delete.ineffectual.

Informs #115881
Informs #114421

Epic: none

Release note (ops change): The cluster settings
storage.single_delete.crash_on_invariant_violation.enabled and storage.single_delete.crash_on_ineffectual.enabled default to true since these can be indicative of a serious bug that could corrupt data.

116549: sql,opt: don't validate AOST during session migration r=rafiss a=rafiss

When re-preparing a statement for a session migration, we want to skip evaluating and validating the AS OF SYSTEM TIME clause. During session migrations, we know that the statement will just be prepared, and not executed, and each statement could have different AOST timestamps. Therefore it is incorrect to evaluate the AOST clause and fix the transaction timestamp.

No release note since this fixes a bug that only affects Serverless. See [here](https://cockroachlabsgcp.splunkcloud.com/en-US/app/search/search?earliest=1702141875&latest=1702401075&q=search%20index%3Dcc-app-crdb*%20%20%22could%20not%20prepare%20statement%20during%20session%20migration%22%20host_ip%3D%2210.4.0.19%22&display.page.search.mode=verbose&dispatch.sample_ratio=1&display.general.type=events&display.page.search.tab=events&workload_pool=standard_perf&sid=1702579453.274591) for an example of the error.

Epic: None
Release note: None

116567: roachtest: run workload after 8tb OR roachtest r=adityamaru a=msbutler

Previously the tpce workload would not run after the 8tb OR test, because of a misconfiguration in the test specs. This fixes this bug.

Epic: none

Release note: none

116580: roachtest: fix mininum version calculation in `UploadWorkload` r=rickystewart,DarrylWong a=renatolabs

In ARM64 builds, the `workload` binary is only available in 23.2+.

Epic: none

Release note: None

116587: roachtest: don't run `schemachange` workload with upgrade migrations r=annrpom,DarrylWong a=renatolabs

This has been flaking on all branches.

Informs: #116586.
Fixes: #116304.
Fixes: #116425.
Fixes: #116357.

Release note: None

Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
Co-authored-by: Michael Butler <butler@cockroachlabs.com>
Co-authored-by: Renato Costa <renato@cockroachlabs.com>
@craig craig bot closed this as completed in 06eaaa0 Dec 15, 2023
@craig craig bot closed this as completed in #116587 Dec 15, 2023
@blathers-crl blathers-crl bot mentioned this issue Dec 15, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Dec 15, 2023
@renatolabs
roachtest: don't run schemachange workload with upgrade migrations
f72f2c0 
This has been flaking on all branches.

Informs: #116586.
Fixes: #116304.
Fixes: #116425.
Fixes: #116357.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Dec 15, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Dec 15, 2023
@renatolabs
roachtest: don't run schemachange workload with upgrade migrations
3f01c79 
This has been flaking on all branches.

Informs: #116586.
Fixes: #116304.
Fixes: #116425.
Fixes: #116357.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Dec 15, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Dec 15, 2023
@renatolabs
roachtest: don't run schemachange workload with upgrade migrations
c939b74 
This has been flaking on all branches.

Informs: #116586.
Fixes: #116304.
Fixes: #116425.
Fixes: #116357.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team
Projects
No open projects
Test Engineering
Status: Done
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

roachtest: don't run schemachange workload with upgrade migrations renatolabs/cockroach
2 participants
@cockroach-teamcity @renatolabs