Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admission: disk bandwidth limiter integrations #121779

Open
1 of 5 tasks
aadityasondhi opened this issue Apr 4, 2024 · 0 comments
Open
1 of 5 tasks

admission: disk bandwidth limiter integrations #121779

aadityasondhi opened this issue Apr 4, 2024 · 0 comments
Assignees
@aadityasondhi
Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-admission-control Admission Control

Comments

@aadityasondhi
Copy link
Collaborator

aadityasondhi commented Apr 4, 2024 •
edited
Loading

Parent tracking issue for some integrations, we would make after #86857 is complete:

Write traffic integrations:

Read traffic integrations:

Jira issue: CRDB-37523

Epic CRDB-37479
@aadityasondhi aadityasondhi added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-admission-control T-admission-control Admission Control labels Apr 4, 2024
@aadityasondhi aadityasondhi self-assigned this Aug 6, 2024
@andrewbaptist andrewbaptist mentioned this issue Dec 12, 2024
Closed
aadityasondhi added a commit to aadityasondhi/cockroach that referenced this issue Dec 17, 2024
@aadityasondhi
admission: turn on snapshot ingest bandwidth control by default
52906f1 
With cockroachdb#133310 merged, and
promising results from internal experimentation, we can turn this
setting on by default.

Informs: cockroachdb#121779.

Release note (ops change):
`kvadmission.store.snapshot_ingest_bandwidth_control.enabled` is now
'true' by default. This will enable disk bandwdith based Admission
Control for range snapshot ingests. It requires the provisioned
bandwidth to be set using `kvadmission.store.provisioned_bandwidth`.
aadityasondhi added a commit to aadityasondhi/cockroach that referenced this issue Dec 17, 2024
@aadityasondhi
admission: turn on snapshot ingest bandwidth control by default
154a905 
With cockroachdb#133310 merged, and
promising results from internal experimentation, we can turn this
setting on by default.

Informs: cockroachdb#121779.

Release note (ops change):
`kvadmission.store.snapshot_ingest_bandwidth_control.enabled` is now
'true' by default. This will enable disk bandwidth based Admission
Control for range snapshot ingests. It requires the provisioned
bandwidth to be set using `kvadmission.store.provisioned_bandwidth`.
@aadityasondhi aadityasondhi mentioned this issue Dec 17, 2024
Merged
aadityasondhi added a commit to aadityasondhi/cockroach that referenced this issue Dec 18, 2024
@aadityasondhi
admission: turn on snapshot ingest bandwidth control by default
8d4de0e 
With cockroachdb#133310 merged, and
promising results from internal experimentation, we can turn this
setting on by default.

Informs: cockroachdb#121779.

Release note (ops change):
`kvadmission.store.snapshot_ingest_bandwidth_control.enabled` is now
'true' by default. This will enable disk bandwidth based Admission
Control for range snapshot ingests. It requires the provisioned
bandwidth to be set using `kvadmission.store.provisioned_bandwidth`.
craig bot pushed a commit that referenced this issue Dec 18, 2024
@aadityasondhi @rickystewart
Merge #137618 #137697
f8c78f2 
137618: admission: turn on snapshot ingest bandwidth control by default r=sumeerbhola a=aadityasondhi

With #133310 merged, and promising results from internal experimentation, we can turn this setting on by default.

Informs: #121779.

Release note (ops change):
`kvadmission.store.snapshot_ingest_bandwidth_control.enabled` is now 'true' by default. This will enable disk bandwidth based Admission Control for range snapshot ingests. It requires the provisioned bandwidth to be set using `kvadmission.store.provisioned_bandwidth`.

137697: build: add configuration to opt into PGO r=rail a=rickystewart

Epic: CRDB-41952
Part of: CRDB-44693
Release note: None

Co-authored-by: Aaditya Sondhi <20070511+aadityasondhi@users.noreply.github.com>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadityasondhi aadityasondhi

Labels
A-admission-control C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-admission-control Admission Control
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aadityasondhi