-
Notifications
You must be signed in to change notification settings - Fork 4k
Closed
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-kvKV TeamKV Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.release-blockerIndicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Description
While working on adding 24.3 versions (#128616), I noticed the version-upgrade roachtest failing, with one node crashing here:
runtime error: index out of range [24] with length 24
* | github.com/cockroachdb/cockroach/pkg/kv/kvserver.(*Store).HandleRaftUncoalescedRequest
Code:
s.metrics.RaftRcvdMessages[req.Message.Type].Inc(1)Two new message types were added after 24.2 branched in #128426
Looks like this problem is in 24.1 as well, which will be problematic in 24.1 -> 24.3 upgrades. Edit: actually, if this was true, we would have seen failures on upgrades test on master and on 24.2. To be investigated some more
Jira issue: CRDB-41178
Metadata
Metadata
Assignees
Labels
C-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-kvKV TeamKV Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.release-blockerIndicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.