Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: backup-restore/mixed-version failed #130469

Closed
cockroach-teamcity opened this issue Sep 11, 2024 · 1 comment · Fixed by #130508
Closed

roachtest: backup-restore/mixed-version failed #130469

cockroach-teamcity opened this issue Sep 11, 2024 · 1 comment · Fixed by #130508
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Sep 11, 2024 •
edited by cockroach-jira-scripts
Loading

roachtest.backup-restore/mixed-version failed with artifacts on master @ 1b0a374fd2a101cebcfb24cff4b3b57795ad1df6:

(mixedversion.go:710).Run: EOF [owner=test-eng] [owner=test-eng]
test artifacts and logs in: /artifacts/backup-restore/mixed-version/cpu_arch=arm64/run_1

Parameters:

  • ROACHTEST_arch=arm64
  • ROACHTEST_cloud=gce
  • ROACHTEST_coverageBuild=false
  • ROACHTEST_cpu=4
  • ROACHTEST_encrypted=false
  • ROACHTEST_fs=ext4
  • ROACHTEST_localSSD=false
  • ROACHTEST_runtimeAssertionsBuild=false
  • ROACHTEST_ssd=0
Help

See: roachtest README

See: How To Investigate (internal)

See: Grafana

Same failure on other branches

/cc @cockroachdb/test-eng

This test on roachdash | Improve this report!

Jira issue: CRDB-42067
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-testeng TestEng Team labels Sep 11, 2024
@renatolabs renatolabs removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Sep 11, 2024
@renatolabs
Copy link
Contributor

Ownership assignment bug: this should have been labeled as a monitor_failure flake, but it wasn't because the mixedversion framework also changes ownership when an error happens before any user functions had the chance to run.

@renatolabs renatolabs mentioned this issue Sep 11, 2024
Merged
craig bot pushed a commit that referenced this issue Sep 11, 2024
@renatolabs
Merge #130508
240bcb7 
130508: roachtest: find error ownership in the innermost error in the chain r=srosenberg a=renatolabs

This PR is very similar to #124403, but applying the same logic when finding `ErrorWithOwnership` instances (instead of `TransientErorr` instances). Specifically, we look for the innermost instance of an error with ownership to decide what ownership to apply. The idea is that ownership should be assigned based on the "first" error observed during the test.

Fixes: #130469

Release note: None

Co-authored-by: Renato Costa <renato@cockroachlabs.com>
@craig craig bot closed this as completed in ac5fd58 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-testeng TestEng Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: find error ownership in the innermost error in the chain renatolabs/cockroach
2 participants
@cockroach-teamcity @renatolabs