Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: remove replace directive for google.golang.org/protobuf #134941

Closed
tbg opened this issue Nov 12, 2024 · 1 comment · Fixed by #134943
Closed

go.mod: remove replace directive for google.golang.org/protobuf #134941

tbg opened this issue Nov 12, 2024 · 1 comment · Fixed by #134943
Labels
A-build-system C-investigation Further steps needed to qualify. C-label will change.

Comments

@tbg
Copy link
Member

tbg commented Nov 12, 2024

#104302 (comment) introduces a replace directive

replace google.golang.org/protobuf => google.golang.org/protobuf v1.29.1

In the meantime, our google protobuf version has been upgraded to v1.3.2 (though I don't know what motivated the last upgrade1), and is likely to keep drifting ahead.

This problem is likely connected (in ways I am still understanding) to gogo/protobuf (which we use) and the grpc version, and contributes to friction in relation to these dependencies.

We should figure out what it would take to remove the above replace directive.

Jira issue: CRDB-44307

Footnotes

  1. https://github.com/cockroachdb/cockroach/commit/614323229514f307e98029c1b0b1b8740889e2af#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L68

@tbg tbg added C-investigation Further steps needed to qualify. C-label will change. A-build-system labels Nov 12, 2024
@tbg tbg changed the title go.mod: remove replace directive for `g go.mod: remove replace directive for google.golang.org/protobuf Nov 12, 2024
@tbg
Copy link
Member Author

tbg commented Nov 12, 2024

#134943 seems to fix it - it builds locally, let's see what CI says.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant