-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.mod: switch to gogoproto fork #134918
go.mod: switch to gogoproto fork #134918
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a world here in which we don't need a version in the replace directive? The moment you pin a version, you basically bypass version requirement resolution. I would love to get rid of the replace line for protobuf, which I seem to remember is causing us a lot of trouble and this is also somehow related to gogoproto (it isn't compatible with v2 protobuf?)
I know this isn't exactly in your critical path, but I think we have a little dependency hell here. Forking gogoproto can probably help here, but if we're pinning a version it could also go the other way. Could we get a sense of how deep the pit is? I'm happy to team up on that.
Nevermind, we have to provide a version on the right: https://go.dev/ref/mod#go-mod-file-replace Re: protobuf, we have I'm poking at it a bit in #134941. |
How would that work? Our binary must contain exactly one version of the library.. |
TFTR! bors r+ |
134525: kvserver: avoid key heap allocation in multiSSTWriter.rolloverSST r=tbg a=sumeerbhola rolloverSST is called for every key-value pair in the incoming snapshot, and the key parameter was inadvertently escaping to the heap. This was 20% of the number of allocations on a node in the 150 node cluster test. Epic: none Release note: None 134918: go.mod: switch to gogoproto fork r=RaduBerinde a=RaduBerinde Use `github.com/cockroachdb/gogoproto` instead of `github.com/gogo/protobuf`. The former already has a new `omitempty` option that can clean up some existing hacks, and we want to make more improvements to the generated code. Fixes #134805 Release note: None Co-authored-by: sumeerbhola <sumeer@cockroachlabs.com> Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Build failed (retrying...): |
bors r- |
Canceled. |
c7bc187
to
c908f57
Compare
Use `github.com/cockroachdb/gogoproto` instead of `github.com/gogo/protobuf`. The former already has a new `omitempty` option that can clean up some existing hacks, and we want to make more improvements to the generated code. Fixes cockroachdb#134805 Release note: None
c908f57
to
0698ba2
Compare
bors r+ |
Use
github.com/cockroachdb/gogoproto
instead ofgithub.com/gogo/protobuf
. The former already has a newomitempty
option that can clean up some existing hacks, and we want to make more
improvements to the generated code.
Fixes #134805
Release note: None