distsql: roundtrip to string does not respect precedence of ::: and -

[eisenstatdavid]

Run

CREATE TABLE t (c int PRIMARY KEY);
INSERT INTO t VALUES (1), (2), (3);
SELECT (-9223372036854775808) ::: INT;
SELECT c FROM t WHERE (c, c) < (1, -9223372036854775808);

and get

Error: pq: ($0, $0) < (1, - 9223372036854775808:::INT): tuples ($0, $0), (1, - 9223372036854775808:::INT) are not comparable at index 2: numeric constant out of int64 range

Turn off distsql and the problem goes away.

[petermattis]

For known-limitations, we've been setting the milestone to when we expect the issue to be fixed.

[vivekmenezes]

This is still an issue:

root@:26257/test> SELECT c FROM t WHERE (c, c) < (1, -9223372036854775808);
pq: ($0, $0) < (1, -9223372036854775808:::INT): tuples ($0, $0), (1, -9223372036854775808:::INT) are not comparable at index 2: numeric constant out of int64 range
root@:26257/test> set distsql=off;
SET

Time: 319.448µs

root@:26257/test> SELECT c FROM t WHERE (c, c) < (1, -9223372036854775808);
+---+
| c |
+---+
+---+
(0 rows)

Time: 1.292733ms

[vivekmenezes]

I'm still looking at this, but the problem is that via the distsql path -9223372036854775808 is converted to an intVal type, while using the normal path it is converted to an int64Val

[RaduBerinde]

The problem is that we are serializing the filter expression as (@1, @1) < (1:::INT, -9223372036854775808:::INT).

This doesn't work:

root@:26257/test> SELECT -9223372036854775808:::INT;
pq: numeric constant out of int64 range

The correct serialization would be (@1, @1) < (1:::INT, '-9223372036854775808':::INT)

[RaduBerinde]

I can take this, I know what piece of code needs to be fixed.