Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: use Hibernate's test suite #15821

Closed
cuongdo opened this issue May 9, 2017 · 5 comments
Closed

sql: use Hibernate's test suite #15821

cuongdo opened this issue May 9, 2017 · 5 comments
Assignees
@BramGruneir
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-testing Testing tools and infrastructure A-tools-hibernate Issues that pertain to Hibernate integration. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Milestone
2.1

Comments

@cuongdo
Copy link
Contributor

cuongdo commented May 9, 2017

Currently, we have a basic test for Hibernate compatibility. Because Hibernate is popular with our users, we should increase our Hibernate test coverage to more proactively discover issues and regressions.

A relatively straightforward way to do that is to regularly run the subset of Hibernate test suite that is relevant to CockroachDB.

@jordanlewis would be a great person to consult with for this task
@cuongdo cuongdo added this to the 1.1 milestone May 9, 2017
@cuongdo cuongdo added the A-sql-pgcompat Semantic compatibility with PostgreSQL label May 9, 2017
@cuongdo
Copy link
Contributor Author

cuongdo commented Jul 7, 2017

Where do this stand now?

@justinj
Copy link
Contributor

justinj commented Jul 7, 2017

I'm currently re-running the test suite since the recent alias additions should have improved our compatibility a decent amount. I'm going to try to bucket all the failures and see where we stand.

@vivekmenezes vivekmenezes removed this from the 1.1 milestone Aug 30, 2017
@vivekmenezes
Copy link
Contributor

This is a fix going into our fork of the Hibernate repo. Taking it out of the 1.1 release.

@jordanlewis jordanlewis added the A-testing Testing tools and infrastructure label Apr 26, 2018
@knz knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Apr 28, 2018
@justinj justinj mentioned this issue Apr 28, 2018
Closed
18 tasks
@BramGruneir BramGruneir mentioned this issue Jun 12, 2018
Closed
14 tasks
@BramGruneir BramGruneir added the A-tools-hibernate Issues that pertain to Hibernate integration. label Jun 14, 2018
@knz knz assigned BramGruneir and unassigned justinj Jul 5, 2018
@knz knz added this to the 2.1 milestone Jul 23, 2018
@BramGruneir
Copy link
Member

This is now completed. See #30565

@vivekmenezes
Copy link
Contributor

vivekmenezes commented Sep 27, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BramGruneir BramGruneir

Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL A-testing Testing tools and infrastructure A-tools-hibernate Issues that pertain to Hibernate integration. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
6 participants
@jordanlewis @justinj @knz @cuongdo @BramGruneir @vivekmenezes