pkg/ccl/testccl/workload/schemachange/schemachange_test: TestWorkload failed

[cockroach-teamcity]

pkg/ccl/testccl/workload/schemachange/schemachange_test.TestWorkload failed on release-26.1 @ 70a14c3560b51a1bfc53204c9fc72b84afb3ac93:

  ],
  "usesDeclarativeSchemaChanger": true
 }
}
    schema_change_external_test.go:165: 
        	Error Trace:	pkg/ccl/testccl/workload/schemachange/schema_change_external_test.go:165
        	Error:      	Received unexpected error:
        	            	***FAIL; Failed to receive an execution error when errors were expected
        	            	(1) forced error mark
        	            	  | "fatal error when running txn"
        	            	  | github.com/cockroachdb/errors/withstack/*withstack.withStack::
        	            	Wraps: (2)
        	            	Wraps: (3) attached stack trace
        	            	  -- stack trace:
        	            	  | github.com/cockroachdb/cockroach/pkg/workload/schemachange.(*opStmt).executeStmt
        	            	  | 	pkg/workload/schemachange/operation_generator.go:3417
        	            	  | github.com/cockroachdb/cockroach/pkg/workload/schemachange.(*schemaChangeWorker).runInTxn
        	            	  | 	pkg/workload/schemachange/schemachange.go:613
        	            	  | github.com/cockroachdb/cockroach/pkg/workload/schemachange.(*schemaChangeWorker).run
        	            	  | 	pkg/workload/schemachange/schemachange.go:701
        	            	  | pkg/ccl/testccl/workload/schemachange/schemachange_test_test.TestWorkload.TestWorkload.func5.func7
        	            	  | 	pkg/ccl/testccl/workload/schemachange/schema_change_external_test.go:154
        	            	  | golang.org/x/sync/errgroup.(*Group).Go.func1
        	            	  | 	external/org_golang_x_sync/errgroup/errgroup.go:93
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1693
        	            	Wraps: (4) ***FAIL; Failed to receive an execution error when errors were expected
        	            	Error types: (1) *markers.withMark (2) *schemachange.ErrorState (3) *withstack.withStack (4) *errutil.leafError
        	Test:       	TestWorkload
{
 "message": "Inspect Job Errors",
 "jobs": [
  {
   "jobId": 1137343207873609729,
   "status": "no errors reported"
  }
 ]
}
Schema Workload Stats
Total Schema Statements Executed = 27
Total Schema Statements Succeeded = 27
Total Schema Statement Expected Failures = 0
Total Transactions Committed = 14
Total Transactions Rolled Back = 17
Total Transactions Executed = 31
    schema_change_external_test.go:118: backup, tracing data, and system table dumps in /mnt/engflow/worker/work/0/exec/bazel-out/k8-fastbuild/testlogs/pkg/ccl/testccl/workload/schemachange/schemachange_test/run_3_of_10/test.outputs/logTestWorkload994416116
    schema_change_external_test.go:127: running DROP with use_declarative_schema_changer = off
    panic.go:615: -- test log scope end --
test logs left over in: outputs.zip/logTestWorkload994416116
--- FAIL: TestWorkload (20.06s)

Parameters:

• attempt=1
• run=3
• shard=1

Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-foundations

This test on roachdash | Improve this report!

Jira issue: CRDB-58296

[spilchen]

Here is the error:

{
 "workerId": 0,
 "clientTimestamp": "05:46:45.832615",
 "ops": [
  "BEGIN",
  {
   "sql": "ALTER TABLE public.table_w1_4 DROP COLUMN col4_w1_34",
   "expectedExecErr": "2BP01",
   "potentialExecErr": "2BP01"
  }
 ],
 "expectedExecErrors": "2BP01",
 "expectedCommitErrors": "",
 "message": "***FAIL; Failed to receive an execution error when errors were expected",
 "errorState": {
  "expectedErrors": [
   "2BP01"
  ],
  "potentialErrors": [
   "2BP01"
  ],

[spilchen]

There was a self-referential FK on the table. Inside og.columnIsDependedOn, it returns true if it find a FK. This is what caused the pgcode.DependentObjectsStillExist to be expected:

cockroach/pkg/workload/schemachange/operation_generator.go

Line 1738 in 82dec05

{code: pgcode.DependentObjectsStillExist, condition: columnIsDependedOn},

We recently tried to cleanup this function to no longer detect FK dependencies (in #159188), but og.columnIsDependedOn was missed.

[fqazi]

Same as: #159952