Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow the insertion of empty keys #17

Closed
andybons opened this issue Jun 3, 2014 · 4 comments
Closed

Disallow the insertion of empty keys #17

andybons opened this issue Jun 3, 2014 · 4 comments
Assignees
@tbg

Comments

@andybons
Copy link
Contributor

andybons commented Jun 3, 2014

From @Tobstar87:

I'm wondering if we allow empty keys to be inserted. The rockdb handler doesn't handle it very well, it will crash whenever encountering Key("") for anything that's not an insert as it seeks to &start[0] (similarly to my recent bug fix in rocksdb.scan()).
Either we'll have to disallow that key or treat it differently.
@andybons
Copy link
Contributor Author

andybons commented Jun 3, 2014

I think we should disallow the insertion of empty keys.

@spencerkimball

@spencerkimball
Copy link
Member

Agreed. It makes no sense.

@andybons andybons changed the title Check handling of empty keys Disallow the insertion of empty keys Jun 3, 2014
@tbg
Copy link
Member

tbg commented Jun 3, 2014

Also agree.

@andybons
Copy link
Contributor Author

andybons commented Jun 3, 2014

@Tobstar87 wanna tackle this? up to you :) Just assign to yourself if so.

@tbg tbg self-assigned this Jun 3, 2014
@tbg tbg closed this as completed Jun 5, 2014
@tbg tbg mentioned this issue Apr 12, 2016
Closed
@zhaoyuxi zhaoyuxi mentioned this issue Aug 16, 2016
Closed
soniabhishek pushed a commit to soniabhishek/cockroach that referenced this issue Feb 15, 2017
Merge pull request cockroachdb#17 from crowdflux/himanshu-github
77ea907 
logging fluID in some error
@tbg tbg mentioned this issue Oct 13, 2017
Closed
@bra-fsn bra-fsn mentioned this issue Jul 12, 2019
Closed
@petermattis petermattis mentioned this issue Dec 11, 2019
Closed
@blathers-crl blathers-crl bot mentioned this issue Apr 19, 2020
Closed
@tbg tbg mentioned this issue Mar 15, 2023
Closed
pav-kv pushed a commit to pav-kv/cockroach that referenced this issue Mar 5, 2024
@tbg
Merge pull request cockroachdb#17 from daman1807/main
7357439 
closes etcd-io/raft#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybons @tbg @spencerkimball