sql: INT4 column type not reported as INT4 when inspecting column types (SHOW CREATE, errors etc)

[a-robinson]

According to https://www.cockroachlabs.com/docs/stable/int.html#names-and-aliases, INT4 is treated as a 32-bit type that can't simply be aliased to a full 64-bit INTEGER. However, the actual code does convert INT4 columns to INTEGER on both v1.1.4 and v2.0.1:

root@:26257/> create database foo;                                                                                                                                                                          CREATE DATABASE

Time: 5.524673ms

root@:26257/> create table foo.bar (x INT4, y INT, z INT2);
CREATE TABLE

Time: 5.551593ms

root@:26257/> show create table foo.bar;
+---------+---------------------------------------+
|  Table  |              CreateTable              |
+---------+---------------------------------------+
| foo.bar | CREATE TABLE bar (                    |
|         |                                       |
|         |     x INTEGER NULL,                   |
|         |                                       |
|         |     y INT NULL,                       |
|         |                                       |
|         |     z SMALLINT NULL,                  |
|         |                                       |
|         |     FAMILY "primary" (x, y, z, rowid) |
|         |                                       |
|         | )                                     |
+---------+---------------------------------------+
(1 row)

Time: 7.215492ms

Which is wrong -- the code or the docs?

[a-robinson]

Reported by @borovan on Gitter.

[a-robinson]

Oh, weird. It does do 32-bit int validation even though it claims to be INTEGER:

root@:26257/> insert into foo.bar values (2147483647, 0, 0);
INSERT 1

Time: 2.085641ms

root@:26257/> insert into foo.bar values (2147483648, 0, 0);
pq: integer out of range for type INTEGER (column "x")

[knz]

The error is in the output of SHOW CREATE TABLE and the generation of the text of the error messages. Underneath in the table descriptor the type is different.