Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: data race in multi-cpu #2786

Closed
tamird opened this issue Oct 6, 2015 · 2 comments · Fixed by #2908
Closed

log: data race in multi-cpu #2786

tamird opened this issue Oct 6, 2015 · 2 comments · Fixed by #2908
Labels
C-test-failure Broken test (automatically or manually discovered).

Comments

@tamird
Copy link
Contributor

tamird commented Oct 6, 2015

https://circleci.com/gh/cockroachdb/cockroach/8304

https://circle-artifacts.com/gh/cockroachdb/cockroach/8304/artifacts/0/tmp/circle-artifacts.bmXCP9T/testrace.log

looks like we're logging something during test setup. logging singleton strikes again!
@tamird tamird added C-test-failure Broken test (automatically or manually discovered). multi-cpu labels Oct 6, 2015
@tamird tamird changed the title data race in multi-cpu log: data race in multi-cpu Oct 6, 2015
@tbg
Copy link
Member

tbg commented Oct 23, 2015

blocks #1839

@tbg tbg mentioned this issue Oct 23, 2015
Merged
@tbg
Copy link
Member

tbg commented Oct 23, 2015

yeah, this one is going to be awkward to completely avoid for those tests that manually run cobra commands while other goroutines might still be active. The update of the flag would need to lock logging.mu in util/log, but the flag is in a subpackage that isn't allowed to reach out to log. That leaves more awkward hacks such as having a lock on the logflags package which is set to logging.mu in util/logs init. Well.

@tbg tbg mentioned this issue Oct 23, 2015
Merged
@tbg tbg closed this as completed in #2908 Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-test-failure Broken test (automatically or manually discovered).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

actually lock atomically on {also,}toStderr tbg/cockroach
2 participants
@tamird @tbg