opt: GROUP BY panics on invalid ARRAY aggregations #30412
Assignees
Labels
A-sql-optimizer
SQL logical planning and optimizations.
backport-2.1.x
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
S-2-temp-unavailability
Temp crashes or other availability problems. Can be worked around or resolved by restarting.
Milestone
Comments
rjnn
added
S-2-temp-unavailability
|
is this opt-specific? |
|
(in general I'd advise copy-pasting the full stack trace in an issue report) |
knz
added
the
C-bug
|
Yes, with the optimizer turned off, one gets the sane message Here's a full stack: |
|
Local Execution catches this error case well into planning. I modified the code to emit the stack trace where the error was emitted: This isn't caught at typechecking. Since it is only caught by the planning apparatus, |
|
Assigned to @andy-kimball for triage. |
|
Rebecca, can you take a look? Looks like a probably SRF issue. |
rytaft
added a commit
to rytaft/cockroach
that referenced
this issue
Sep 20, 2018
Instead of panicking, we now throw an appropriate error. Fixes cockroachdb#30412 Release note (bug fix): Fixed a panic that occurred when a generator function such as unnest was used in the SELECT list in the presence of GROUP BY.
craig bot
pushed a commit
that referenced
this issue
Sep 20, 2018
30405: roachtest: mark acceptance as stable r=petermattis a=tschottdorf all of its subtests are already stable, but in running a test locally I noticed that the top-level test was marked as passing as unstable. I'm not sure, but this might mean that the top-level test would actually not fail? Either way, better to mark it as stable explicitly. We should also spend some thought on how diverging notions of Stable in sub vs top level test are treated, not sure that this is well-defined. Release note: None 30446: opt: fix panic when srf used with GROUP BY r=rytaft a=rytaft Instead of panicking, we now throw an appropriate error. Fixes #30412 Release note (bug fix): Fixed a panic that occurred when a generator function such as unnest was used in the SELECT list in the presence of GROUP BY. 30450: roachtest: remove now-unnecessary hack r=petermattis a=tschottdorf Closes #27717. Release note: None 30451: storage: give TestReplicateRemovedNodeDisruptiveElection more time r=petermattis a=tschottdorf Perhaps: Fixes #27253. Release note: None 30452: storage: de-flake TestReplicaIDChangePending r=petermattis a=tschottdorf setReplicaID refreshes the proposal and was thus synchronously writing to the commandProposed chan. This channel could have filled up due to an earlier reproposal already, deadlocking the test. Fixes #28132. Release note: None 30455: testcluster: improve AddReplicas check r=petermattis a=tschottdorf AddReplicas was verifying that a replica had indeed been added, but there's no guarantee that the replicate queue wouldn't have removed it in the meantime. Attempt to work around this somewhat. The real solution is not to provide that guarantee, but some tests likely rely on it (and the failure is extremely rare, i.e. the new for loop basically never runs). Observed in #28368. Release note: None 30456: storage: unskip TestClosedTimestampCanServe for non-race r=petermattis a=tschottdorf Fixes #28607. Release note: None Co-authored-by: Tobias Schottdorf <tobias.schottdorf@gmail.com> Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>
rytaft
added a commit
to rytaft/cockroach
that referenced
this issue
Sep 20, 2018
Instead of panicking, we now throw an appropriate error. Fixes cockroachdb#30412 Release note (bug fix): Fixed a panic that occurred when a generator function such as unnest was used in the SELECT list in the presence of GROUP BY.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Minimal reproduction:
select 0, unnest(array[0]) group by 1panics with:
This should gracefully fail, not crash the server.
The text was updated successfully, but these errors were encountered: