Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: DELETE does not complete for 8000 rows, but does for 2000-5000 #31793

Closed
knz opened this issue Oct 24, 2018 · 4 comments
Closed

sql: DELETE does not complete for 8000 rows, but does for 2000-5000 #31793

knz opened this issue Oct 24, 2018 · 4 comments
Labels
A-sql-mutations Mutation statements: UPDATE/INSERT/UPSERT/DELETE. C-investigation Further steps needed to qualify. C-label will change.

Comments

@knz
Copy link
Contributor

knz commented Oct 24, 2018

Describe the problem

DELETE on a table completes in seconds for 2000-5000 rows, but hangs (or perhaps completes in minutes) for 8000.

@bdarnell suggests perhaps max_refresh_span_bytes is involved, but no investigation has shown this yet.

To Reproduce

TBD

Expected behavior

DELETE latency proportional to number of rows deleted.

Environment:

2.1 on Linux

Additional context

Reported by customer K
@knz knz added C-investigation Further steps needed to qualify. C-label will change. A-sql-mutations Mutation statements: UPDATE/INSERT/UPSERT/DELETE. labels Oct 24, 2018
@knz
Copy link
Contributor Author

knz commented Oct 24, 2018

@awoods187 could you approach the user and ask them to provide repro details suitable for publication on github so we have something to work with.

@awoods187
Copy link
Contributor

@andy-kimball can you comment here? Would like to see if we can fill in on our own before reaching out

@andy-kimball
Copy link
Contributor

I believe @nvanbenschoten located the root cause for this and will be making a change to the default value for kv.closed_timestamp.target_duration. Nathan, if that's correct, can your team take over this issue and close it down once fix is in?

@nvanbenschoten
Copy link
Member

Yeah, closing now that #31841 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-mutations Mutation statements: UPDATE/INSERT/UPSERT/DELETE. C-investigation Further steps needed to qualify. C-label will change.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knz @nvanbenschoten @awoods187 @andy-kimball