release-2.1: closedts: bump kv.closed_timestamp.target_duration default #31841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change bumps the closed timestamp target duration to 30s. We're not using the timestamp except in special cases in 2.1, so it doesn't make sense for it to be so low. Release note: None
|
This change is |
|
LGTM
On Thu, Oct 25, 2018 at 1:03 AM cockroach-teamcity ***@***.***> wrote:
This change is [image: Reviewable]
<https://reviewable.io/reviews/cockroachdb/cockroach/31841>
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#31841 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135PgallMDAnrfC1MKYCQxWUNYoQZeks5uoPHGgaJpZM4X5NWc>
.
--
…-- Tobias
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #31837.
Planning to make it into 2.1.0.
/cc @cockroachdb/release
This change bumps the closed timestamp target duration to 30s. We're not
using closed timestamps, except in special cases in 2.1, so it doesn't make
sense for the setting to be so low if it risks pushing live transactions.
Release note: None