Skip to content

Commit

Permalink
Merge pull request #31841 from nvanbenschoten/backport2.1-31837
Browse files Browse the repository at this point in the history
release-2.1: closedts: bump kv.closed_timestamp.target_duration default
  • Loading branch information
nvanbenschoten committed Oct 25, 2018
2 parents 0dba537 + f3df3e9 commit f0dd1dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion docs/generated/settings/settings.html
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<tr><td><code>kv.bulk_sst.sync_size</code></td><td>byte size</td><td><code>2.0 MiB</code></td><td>threshold after which non-Rocks SST writes must fsync (0 disables)</td></tr>
<tr><td><code>kv.closed_timestamp.close_fraction</code></td><td>float</td><td><code>0.2</code></td><td>fraction of closed timestamp target duration specifying how frequently the closed timestamp is advanced</td></tr>
<tr><td><code>kv.closed_timestamp.follower_reads_enabled</code></td><td>boolean</td><td><code>false</code></td><td>allow (all) replicas to serve consistent historical reads based on closed timestamp information</td></tr>
<tr><td><code>kv.closed_timestamp.target_duration</code></td><td>duration</td><td><code>5s</code></td><td>if nonzero, attempt to provide closed timestamp notifications for timestamps trailing cluster time by approximately this duration</td></tr>
<tr><td><code>kv.closed_timestamp.target_duration</code></td><td>duration</td><td><code>30s</code></td><td>if nonzero, attempt to provide closed timestamp notifications for timestamps trailing cluster time by approximately this duration</td></tr>
<tr><td><code>kv.raft.command.max_size</code></td><td>byte size</td><td><code>64 MiB</code></td><td>maximum size of a raft command</td></tr>
<tr><td><code>kv.raft_log.synchronize</code></td><td>boolean</td><td><code>true</code></td><td>set to true to synchronize on Raft log writes to persistent storage ('false' risks data loss)</td></tr>
<tr><td><code>kv.range.backpressure_range_size_multiplier</code></td><td>float</td><td><code>2</code></td><td>multiple of range_max_bytes that a range is allowed to grow to without splitting before writes to that range are blocked, or 0 to disable</td></tr>
Expand Down
2 changes: 1 addition & 1 deletion pkg/storage/closedts/setting.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (
var TargetDuration = settings.RegisterNonNegativeDurationSetting(
"kv.closed_timestamp.target_duration",
"if nonzero, attempt to provide closed timestamp notifications for timestamps trailing cluster time by approximately this duration",
5*time.Second,
30*time.Second,
)

// CloseFraction is the fraction of TargetDuration determining how often closed
Expand Down

0 comments on commit f0dd1dc

Please sign in to comment.