Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: add Partitioner operator to handle PARTITION BY clause of window functions #37034

Closed
yuzefovich opened this issue Apr 23, 2019 · 0 comments · Fixed by #37227
Closed

exec: add Partitioner operator to handle PARTITION BY clause of window functions #37034

yuzefovich opened this issue Apr 23, 2019 · 0 comments · Fixed by #37227
Assignees
@yuzefovich
Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@yuzefovich
Copy link
Member

yuzefovich commented Apr 23, 2019 •
edited
Loading

Implement a sorting window partitioner that utilizes a full sort approach, i.e. it sorts its input on PARTITION BY columns and then "runs" a distinct over the ordered input.
@yuzefovich yuzefovich added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-execution Relating to SQL execution. labels Apr 23, 2019
@yuzefovich yuzefovich self-assigned this Apr 23, 2019
@yuzefovich yuzefovich added A-sql-vec SQL vectorized engine and removed A-sql-execution Relating to SQL execution. labels Apr 23, 2019
@yuzefovich yuzefovich mentioned this issue Apr 23, 2019
Closed
6 tasks
@yuzefovich yuzefovich mentioned this issue May 1, 2019
Merged
craig bot pushed a commit that referenced this issue May 8, 2019
@yuzefovich
Merge #37227
d2d9375 
37227: exec: add support for PARTITION BY clause of window functions r=yuzefovich a=yuzefovich

Adds a sorting partitioner that takes care of both PARTITION BY and
ORDER BY clauses. It is probably slower that hashing partitioning,
but that will be added later.

Fixes: #37034.

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
@craig craig bot closed this as completed in #37227 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuzefovich yuzefovich

Labels
A-sql-vec SQL vectorized engine C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exec: add support for PARTITION BY clause of window functions yuzefovich/cockroach
1 participant
@yuzefovich