Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/exec/colserde: TestArrowBatchConverterRandom failed under stress #37755

Closed
cockroach-teamcity opened this issue May 23, 2019 · 3 comments
Closed

sql/exec/colserde: TestArrowBatchConverterRandom failed under stress #37755

cockroach-teamcity opened this issue May 23, 2019 · 3 comments
Assignees
@asubiotto
Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
19.2

Comments

@cockroach-teamcity
Copy link
Member

SHA: https://github.com/cockroachdb/cockroach/commits/e6359159252597cab72855673bcd9334d339c0f9

Parameters:

TAGS=
GOFLAGS=-parallel=4

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=TestArrowBatchConverterRandom PKG=github.com/cockroachdb/cockroach/pkg/sql/exec/colserde TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1304230&tab=buildLog

=== RUN   TestArrowBatchConverterRandom
--- FAIL: TestArrowBatchConverterRandom (0.01s)
    require.go:157: 
        	Error Trace:	arrowbatchconverter_test.go:68
        	Error:      	Not equal: 
        	            	expected: &coldata.memColumn{t:0, col:[]float32{0.5031853, 0.22270694, 0.5930435, 0.72802025, 0.8448427, 0.17051493, 0.20799948, 0.8060506, 0.15756412, 0.7844328, 0.8449728, 0.03883319, 0.49327365, 0.6315165, 0.009869966, 0.3133471, 0.72686964, 0.44061437, 0.60810673, 0.28562224, 0.26556244, 0.48728094, 0.6181515, 0.85545236, 0.6840607, 0.62542903, 0.43284306, 0.6599884, 0.90547353, 0.2893502, 0.12124738, 0.78306854, 0.15403023, 0.8717671, 0.7592205, 0.84481347, 0.8835997, 0.27580765, 0.023648117, 0.8055081, 0.053677786, 0.02891403, 0.13854292, 0.5517053, 0.8900108, 0.81039315, 0.16460283, 0.44108588, 0.26637474, 0.8272323, 0.7269394, 0.45809665, 0.3228572, 0.24134736, 0.46779382, 0.23916657, 0.6449272, 0.03602604, 0.072813295, 0.14903714, 0.20330201, 0.52050567, 0.6369916, 0.5513764, 0.50547653, 0.86386937, 0.5858668, 0.9300088, 0.956392, 0.8856387, 0.40497774, 0.5838886, 0.046204854, 0.7354086, 0.8457489, 0.6183415, 0.6896346, 0.84538376, 0.21987297, 0.68952453, 0.80304146, 0.99183273, 0.28498435, 0.070540585, 0.69512, 0.5134578, 0.36610323, 0.6365363, 0.79390705, 0.2037886, 0.6381076, 0.6576231, 0.99182034, 0.8601379, 0.64693534, 0.7080725, 0.84886, 0.9341553, 0.37652418, 0.5552475, 0.156, 0.905468, 0.5614349, 0.8361953, 0.5664481, 0.96578896, 0.4104095, 0.29171175, 0.5700615, 0.8217599, 0.09340377, 0.6937105, 0.12777273}, nulls:coldata.Nulls{nulls:[]uint8{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0xfe}, hasNulls:true}}
        	            	actual  : &coldata.memColumn{t:0, col:[]float32{0.5031853, 0.22270694, 0.5930435, 0.72802025, 0.8448427, 0.17051493, 0.20799948, 0.8060506, 0.15756412, 0.7844328, 0.8449728, 0.03883319, 0.49327365, 0.6315165, 0.009869966, 0.3133471, 0.72686964, 0.44061437, 0.60810673, 0.28562224, 0.26556244, 0.48728094, 0.6181515, 0.85545236, 0.6840607, 0.62542903, 0.43284306, 0.6599884, 0.90547353, 0.2893502, 0.12124738, 0.78306854, 0.15403023, 0.8717671, 0.7592205, 0.84481347, 0.8835997, 0.27580765, 0.023648117, 0.8055081, 0.053677786, 0.02891403, 0.13854292, 0.5517053, 0.8900108, 0.81039315, 0.16460283, 0.44108588, 0.26637474, 0.8272323, 0.7269394, 0.45809665, 0.3228572, 0.24134736, 0.46779382, 0.23916657, 0.6449272, 0.03602604, 0.072813295, 0.14903714, 0.20330201, 0.52050567, 0.6369916, 0.5513764, 0.50547653, 0.86386937, 0.5858668, 0.9300088, 0.956392, 0.8856387, 0.40497774, 0.5838886, 0.046204854, 0.7354086, 0.8457489, 0.6183415, 0.6896346, 0.84538376, 0.21987297, 0.68952453, 0.80304146, 0.99183273, 0.28498435, 0.070540585, 0.69512, 0.5134578, 0.36610323, 0.6365363, 0.79390705, 0.2037886, 0.6381076, 0.6576231, 0.99182034, 0.8601379, 0.64693534, 0.7080725, 0.84886, 0.9341553, 0.37652418, 0.5552475, 0.156, 0.905468, 0.5614349, 0.8361953, 0.5664481, 0.96578896, 0.4104095, 0.29171175, 0.5700615, 0.8217599, 0.09340377, 0.6937105, 0.12777273}, nulls:coldata.Nulls{nulls:[]uint8{0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff}, hasNulls:false}}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -119,5 +119,5 @@
        	            	   nulls: ([]uint8) (len=15) {
        	            	-   00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 fe     |...............|
        	            	+   00000000  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff     |...............|
        	            	   },
        	            	-  hasNulls: (bool) true
        	            	+  hasNulls: (bool) false
        	            	  }
        	Test:       	TestArrowBatchConverterRandom
@cockroach-teamcity cockroach-teamcity added this to the 19.2 milestone May 23, 2019
@cockroach-teamcity cockroach-teamcity added C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels May 23, 2019
@cockroach-teamcity
Copy link
Member Author

SHA: https://github.com/cockroachdb/cockroach/commits/e6359159252597cab72855673bcd9334d339c0f9

Parameters:

TAGS=
GOFLAGS=-race -parallel=2

To repro, try:

# Don't forget to check out a clean suitable branch and experiment with the
# stress invocation until the desired results present themselves. For example,
# using stress instead of stressrace and passing the '-p' stressflag which
# controls concurrency.
./scripts/gceworker.sh start && ./scripts/gceworker.sh mosh
cd ~/go/src/github.com/cockroachdb/cockroach && \
stdbuf -oL -eL \
make stressrace TESTS=TestArrowBatchConverterRandom PKG=github.com/cockroachdb/cockroach/pkg/sql/exec/colserde TESTTIMEOUT=5m STRESSFLAGS='-maxtime 20m -timeout 10m' 2>&1 | tee /tmp/stress.log

Failed test: https://teamcity.cockroachdb.com/viewLog.html?buildId=1304232&tab=buildLog

        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -661,10 +661,10 @@
        	            	   nulls: ([]uint8) (len=82) {
        	            	-   00000000  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
        	            	-   00000010  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
        	            	-   00000020  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
        	            	-   00000030  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
        	            	-   00000040  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  |................|
        	            	-   00000050  00 80                                             |..|
        	            	+   00000000  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
        	            	+   00000010  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
        	            	+   00000020  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
        	            	+   00000030  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
        	            	+   00000040  ff ff ff ff ff ff ff ff  ff ff ff ff ff ff ff ff  |................|
        	            	+   00000050  ff ff                                             |..|
        	            	   },
        	            	-  hasNulls: (bool) true
        	            	+  hasNulls: (bool) false
        	            	  }
        	Test:       	TestArrowBatchConverterRandom

@asubiotto
Copy link
Contributor

Will be fixed by #37745

@asubiotto
Copy link
Contributor

Forgot to close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asubiotto asubiotto

Labels
C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
19.2
Development

No branches or pull requests
2 participants
@asubiotto @cockroach-teamcity