col{data,serde}: various fixes related to TestArrowBatchConverterRandom #37745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check was previously `!= 0`, which checks if any element is not-null. We change this to fill the rest of the bitmap with 1s similar to when allocating a new bitmap and then checking for a onesMask (i.e. if that check fails, at least one element is 0, or null). This commit also adds naive copying of null bitmaps in coldata.Vec.Copy, which wasn't implemented for some reason. Release note: None
These were modified in place. Release note: None
|
This change is |
solongordon
approved these changes
May 23, 2019
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @asubiotto, @rafiss, and @solongordon)
pkg/sql/exec/coldata/nulls.go, line 268 at r1 (raw file):
for i := 0; i < len(bm); i++ { if bm[i] != onesMask {
Oops, I think maybe you pointed this out when reviewing my code and I forgot to fix it. Thanks.
asubiotto
commented
May 23, 2019
There was a problem hiding this comment.
bors r=solongordon
Reviewable status:
pkg/sql/exec/coldata/nulls.go, line 268 at r1 (raw file):
Previously, solongordon (Solon) wrote…
Oops, I think maybe you pointed this out when reviewing my code and I forgot to fix it. Thanks.
All good!
craig bot
pushed a commit
that referenced
this pull request
May 23, 2019
37744: sql: improve interval math for div and mul r=mjibson a=mjibson In #37582 we added correct `interval * float` semantics. Here we extend that to float division. In addition, change int division to be a wrapper around float division so that remainders are correctly handled. Int multiply has no need to change since it's lossless. Release note (sql change): Correct interval math when multiplying or dividing by floats or ints. 37745: col{data,serde}: various fixes related to TestArrowBatchConverterRandom r=solongordon a=asubiotto See individual commits for details Fixes #37458 Fixes #37692 Co-authored-by: Matt Jibson <matt.jibson@gmail.com> Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details
Fixes #37458
Fixes #37692