sql: improve interval math for div and mul #37744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #37582 we added correct `interval * float` semantics. Here we extend that to float division. In addition, change int division to be a wrapper around float division so that remainders are correctly handled. Int multiply has no need to change since it's lossless. Release note (sql change): Correct interval math when multiplying or dividing by floats or ints.
|
This change is |
solongordon
approved these changes
May 23, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mjibson, @rafiss, @solongordon, and @yuzefovich)
pkg/sql/logictest/testdata/logic_test/datetime, line 1380 at r1 (raw file):
1 day 12:00:00 2 days 12:00:00 2 days 4 days 05:36:31.701948 05:40:07.68 1 mon 15 days 2 mons 15 days 2 mons 4 mons 7 days 00:15:51.058425 7 days 02:03:50.4 1 mon 2 days 04:00:00 16 days 02:00:00 2 mons 4 days 08:00:00 16 days 02:00:00 2 mons 4 days 08:00:00 4 mons 15 days 28:24:59.745978 7 days 14:20:47.04
Weird how it's 4 mons 15 days 28:24:59.745978 rather than 4 mons 16 days 04:24:59.745978, but it matches Postgres so great.
|
bors r+ |
Build failed |
|
bors r+ |
Build failed |
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 23, 2019
37744: sql: improve interval math for div and mul r=mjibson a=mjibson In #37582 we added correct `interval * float` semantics. Here we extend that to float division. In addition, change int division to be a wrapper around float division so that remainders are correctly handled. Int multiply has no need to change since it's lossless. Release note (sql change): Correct interval math when multiplying or dividing by floats or ints. 37745: col{data,serde}: various fixes related to TestArrowBatchConverterRandom r=solongordon a=asubiotto See individual commits for details Fixes #37458 Fixes #37692 Co-authored-by: Matt Jibson <matt.jibson@gmail.com> Co-authored-by: Alfonso Subiotto Marqués <alfonso@cockroachlabs.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37582 we added correct
interval * floatsemantics. Here we extend that tofloat division.
In addition, change int division to be a wrapper around float division so that
remainders are correctly handled. Int multiply has no need to change since it's
lossless.
Release note (sql change): Correct interval math when multiplying or dividing
by floats or ints.