Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Release notes email sign up - design follow up #45187

Closed
5 tasks
Annebirzin opened this issue Feb 18, 2020 · 0 comments · Fixed by #45240
Closed
5 tasks

ui: Release notes email sign up - design follow up #45187

Annebirzin opened this issue Feb 18, 2020 · 0 comments · Fixed by #45240
Assignees
@koorosh
Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category.

Comments

@Annebirzin
Copy link

Annebirzin commented Feb 18, 2020 •
edited
Loading

Design updates related to #45143

  • Update banner to new styling: https://zpl.io/25vg65W
    - partial green background and slightly adjusted illustration

  • remove the 'CLUSTER OVERVIEW' Headline from the overview page (this might be a separate issue, but we don't need this header anymore)

  • update email field to 258px wide

  • Update email field invalid state to change back to valid once proper email address format is typed

  • Update 'X' icon on success toast to match the 'X' icon on the email sign up banner
@Annebirzin Annebirzin added the A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. label Feb 18, 2020
@Annebirzin Annebirzin assigned Annebirzin and koorosh and unassigned Annebirzin Feb 19, 2020
@Annebirzin Annebirzin changed the title Release notes sign up design follow up Release notes email sign up - design follow up Feb 19, 2020
@Annebirzin Annebirzin changed the title Release notes email sign up - design follow up ui: Release notes email sign up - design follow up Feb 19, 2020
koorosh added a commit to koorosh/cockroach that referenced this issue Feb 19, 2020
@koorosh
ui: Adjust styles for Release notes signup panel
805626c 
Resolves: cockroachdb#45187
- Change background image
- Change partial background to green
- Justify panel when resizing window

Release note: None
@koorosh koorosh mentioned this issue Feb 20, 2020
Merged
craig bot pushed a commit that referenced this issue Feb 25, 2020
@koorosh
Merge #45240
0a31f12 
45240: ui: Remove title from Cluster overview page r=dhartunian a=koorosh

Partially resolves: #45187

Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
@craig craig bot closed this as completed in b216efc Feb 25, 2020
@dhartunian dhartunian reopened this Feb 26, 2020
koorosh added a commit to koorosh/cockroach that referenced this issue Feb 28, 2020
@koorosh
ui: Adjust styles for Release notes signup panel
17db09e 
Resolves: cockroachdb#45187
- Change background image
- Change partial background to green
- Justify panel when resizing window

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@koorosh koorosh

Labels
A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: Remove title from Cluster overview page koorosh/cockroach
3 participants
@dhartunian @koorosh @Annebirzin