sql/pgwire: unit tests should check db name qualification

[knz]

Found while investigating #4550.

Currently all Go acceptance tests connect without a db name (so no default db in session) and qualify the db name in all test queries.

There should be some tests in here that connect with a test database pre-populated in the session and then check that queries with unqualified table names succeed.

[tamird]

Does this need to be an acceptance test? Seems like a unit test would
suffice.
On Feb 23, 2016 18:38, "kena" notifications@github.com wrote:

Found while investigating #4550
#4550.

Currently all Go acceptance tests connect without a db name (so no default
db in session) and qualify the db name in all test queries.

There should be some tests in here that connect with a test database
pre-populated in the session and then check that queries with unqualified
table names succeed.

—
Reply to this email directly or view it on GitHub
#4612.

[petermattis]

@dt Didn't you just fix this bug? Is the test coverage now sufficient?

[dt]

TestPGWireDBName checks that an unqualified table name is qualified using the db name that was used when connecting, so yeah.