Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo/geomfn: implement ST_LineInterpolatePoint({geometry,float8}) #48971

Closed
otan opened this issue May 14, 2020 · 0 comments · Fixed by #49742
Closed

geo/geomfn: implement ST_LineInterpolatePoint({geometry,float8}) #48971

otan opened this issue May 14, 2020 · 0 comments · Fixed by #49742
Labels
A-geometry-builtins Builtins which have geometry as args. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience X-nostale Marks an issue/pr that should be ignored by the stale bot

Comments

@otan
Copy link
Contributor

otan commented May 14, 2020 •
edited
Loading

Implement ST_LineInterpolatePoint on arguments {geometry,float8}, which should adopt PostGIS behaviour.

Observers: Please react to this issue if you need this functionality.

For Geometry builtins, please do the following:

  • Ideally add a relevant helper function in pkg/geo/geomfn (parse and output related functions can go in pkg/geo). Add exhaustive unit tests here - you can run through example test cases and make sure that PostGIS and CRDB return the same result within a degree of accuracy (1cm for geography).
    • When using GEOS, you can reference the C API for which functions are available. Unfortunately, Windows is not currently supported when using GEOS.
  • Create a new builtin that references this function in pkg/sql/sem/builtins/geo_builtins.go. Note that we currently do not support optional arguments, so we define functions that have optional arguments once without the optional argument (using the default value in the optional position), and once with the optional argument.
  • Modify the tests in pkg/sql/logictest/testdata/logic_test/geospatial to call this functionality at least once. You can call make testbaselogic FILES='geospatial' TESTFLAGS='-rewrite' to regenerate the output. Tests here should just ensure the builtin is linked end to end (your exhaustive unit tests go the above mentioned packages!).
  • Ensure the documentation is regenerated by calling make buildshort. You can also play with it by calling ./cockroach demo --empty afterwards.
  • Submit your PR - make sure to follow the guidelines from creating your first PR.

You can follow #48552 for an example PR.

The following additional guidance has been issued on implementing this function:

Implemented by GEOS.

🤖 This issue was synced with a spreadsheet by gsheets-to-github-issues by otan on 2023-09-03T23:16:38Z. Changes to titles, body and labels may be overwritten.
@otan otan added A-geometry-builtins Builtins which have geometry as args. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience labels May 14, 2020
@abhishek20123g abhishek20123g mentioned this issue May 31, 2020
Merged
abhishek20123g added a commit to abhishek20123g/cockroach that referenced this issue May 31, 2020
@abhishek20123g
builtin: Implements ST_LineInterpolatePoint and ST_LineInterpolatePoi…
4d35e3c 
…nts builtin functions

Fixes cockroachdb#48971
Fixes cockroachdb#48972

This PR adds following builtin functions
* ST_LineInterpolatePoint{{geometry, float8}}
* ST_LineInterpolatePoints{{geometry, float8, bool}}

which works for LineString only, allows us to determine one or more
interpolated points in the LineString which at an integral multiple
of given fraction of LineString's total length.

Release note (sql change): This PR implement adds the following built-in functions.
* ST_LineInterpolatePoint{{geometry, float8}}
* ST_LineInterpolatePoints{{geometry, float8, bool}}
craig bot pushed a commit that referenced this issue Jun 2, 2020
@abhishek20123g
Merge #49742
cbe7fdc 
49742: geo/geomfn: implement ST_LineInterpolatePoint(s) r=otan a=abhishek20123g

Fixes #48971
Fixes #48972

This PR adds following builtin functions
* ST_LineInterpolatePoint{{geometry, float8}}
* ST_LineInterpolatePoints{{geometry, float8, bool}}

which works for LineString only, allows us to determine one or more
interpolated points in the LineString which at an integral multiple
of given fraction of LineString's total length.

Release note (sql change): This PR implement adds the following built-in functions.
* ST_LineInterpolatePoint{{geometry, float8}}
* ST_LineInterpolatePoints{{geometry, float8, bool}}

Co-authored-by: abhishek20123g <abhishek20123g@gmail.com>
@craig craig bot closed this as completed in cf81e9f Jun 2, 2020
@otan otan added the X-nostale Marks an issue/pr that should be ignored by the stale bot label Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-geometry-builtins Builtins which have geometry as args. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-easy Easy issue to tackle, requires little or no CockroachDB experience X-nostale Marks an issue/pr that should be ignored by the stale bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

geo/geomfn: implement ST_LineInterpolatePoint(s) abhishek20123g/cockroach
1 participant
@otan