Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: clock/monotonic/persistent failed #49358

Closed
cockroach-teamcity opened this issue May 21, 2020 · 2 comments · Fixed by #49800
Closed

roachtest: clock/monotonic/persistent failed #49358

cockroach-teamcity opened this issue May 21, 2020 · 2 comments · Fixed by #49800
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).clock/monotonic/persistent failed on master@1520ad2ba7c926f8043de8b6e044ab35c2f67b13:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/clock/monotonic/persistent/run_1
	clock_monotonic.go:87,clock_monotonic.go:138,test_runner.go:753: Node unexpectedly crashed

	cluster.go:2012,clock_util.go:100,clock_monotonic.go:70,panic.go:563,test.go:279,test.go:254,clock_monotonic.go:87,clock_monotonic.go:138,test_runner.go:753: output in run_091231.255_n1_sudo_service_ntp_stop: cluster.RunL: context canceled
		(1) attached stack trace
		  | main.(*cluster).RunE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2087
		  | [...repeated from below...]
		Wraps: (2) 2 safe details enclosed
		Wraps: (3) output in run_091231.255_n1_sudo_service_ntp_stop
		Wraps: (4) attached stack trace
		  | main.(*cluster).RunL
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2093
		  | main.(*cluster).RunE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2077
		  | main.(*cluster).Run
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2010
		  | main.(*offsetInjector).recover
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_util.go:100
		  | main.runClockMonotonicity.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_monotonic.go:70
		  | runtime.Goexit
		  | 	/usr/local/go/src/runtime/panic.go:563
		  | main.(*test).fatalfInner
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test.go:279
		  | main.(*test).Fatal
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test.go:254
		  | main.runClockMonotonicity
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_monotonic.go:87
		  | main.registerClockMonotonicTests.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_monotonic.go:138
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:753
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (5) cluster.RunL
		Wraps: (6) context canceled
		Error types: (1) *withstack.withStack (2) *safedetails.withSafeDetails (3) *errutil.withMessage (4) *withstack.withStack (5) *errutil.withMessage (6) *errors.errorString

More

Artifacts: /clock/monotonic/persistent

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels May 21, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone May 21, 2020
@cockroach-teamcity
Copy link
Member Author

(roachtest).clock/monotonic/persistent failed on master@fe74c9b3534ef364f7bf9410bb84ed2034e1624b:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/clock/monotonic/persistent/run_1
	clock_monotonic.go:87,clock_monotonic.go:138,test_runner.go:753: Node unexpectedly crashed

	cluster.go:2043,clock_util.go:100,clock_monotonic.go:70,panic.go:563,test.go:279,test.go:254,clock_monotonic.go:87,clock_monotonic.go:138,test_runner.go:753: output in run_104432.528_n1_sudo_service_ntp_stop: cluster.RunL: context canceled
		(1) attached stack trace
		  | main.(*cluster).RunE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2118
		  | [...repeated from below...]
		Wraps: (2) 2 safe details enclosed
		Wraps: (3) output in run_104432.528_n1_sudo_service_ntp_stop
		Wraps: (4) attached stack trace
		  | main.(*cluster).RunL
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2124
		  | main.(*cluster).RunE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2108
		  | main.(*cluster).Run
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2041
		  | main.(*offsetInjector).recover
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_util.go:100
		  | main.runClockMonotonicity.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_monotonic.go:70
		  | runtime.Goexit
		  | 	/usr/local/go/src/runtime/panic.go:563
		  | main.(*test).fatalfInner
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test.go:279
		  | main.(*test).Fatal
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test.go:254
		  | main.runClockMonotonicity
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_monotonic.go:87
		  | main.registerClockMonotonicTests.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/clock_monotonic.go:138
		  | main.(*testRunner).runTest.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/test_runner.go:753
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (5) cluster.RunL
		Wraps: (6) context canceled
		Error types: (1) *withstack.withStack (2) *safedetails.withSafeDetails (3) *errutil.withMessage (4) *withstack.withStack (5) *errutil.withMessage (6) *errors.errorString

More

Artifacts: /clock/monotonic/persistent

See this test on roachdash
powered by pkg/cmd/internal/issues

@nvanbenschoten
Copy link
Member

10:44:32 test.go:325: test failure: 	clock_monotonic.go:87,clock_monotonic.go:138,test_runner.go:753: Node unexpectedly crashed

But this doesn't actually appear to be the case. We should log the error here:

_, err := db.Exec("SHOW DATABASES")

@nvanbenschoten nvanbenschoten self-assigned this Jun 2, 2020
craig bot pushed a commit that referenced this issue Jun 3, 2020
49800: roachtest: log on error in isAlive r=nvanbenschoten a=nvanbenschoten

Closes #49358.

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@craig craig bot closed this as completed in e29011d Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants