Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv,storage: decrease the range descriptor details printed in logs #49502

Closed
knz opened this issue May 24, 2020 · 1 comment
Closed

kv,storage: decrease the range descriptor details printed in logs #49502

knz opened this issue May 24, 2020 · 1 comment
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@knz
Copy link
Contributor

knz commented May 24, 2020

Proposed by @bdarnell in #48076:

we should prefer to log range IDs instead of range descriptors with the possible exception of messages related to splits and merges (and even then it might be worthwhile to consider alternatives, such as logging predecessor/successor range ids instead of keys).

Informs #49457
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-logging In and around the logging infrastructure. labels May 24, 2020
@lunevalex lunevalex mentioned this issue May 27, 2020
Merged
craig bot pushed a commit that referenced this issue May 27, 2020
@lunevalex
Merge #49457
e6e96a4 
49457: roachpb: implement SafeMessager interface in RangeDescriptor r=lunevalex a=lunevalex

Fixes #47461
Informs #49502

RangeDescriptor contains customer specific information, which we should not be logging or exposing in Sentry. This patch improves RangeDescriptor by implementing the SafeMessager interface. This way the logging and Sentry output code can correctly format the RangeDescriptor without customer sensitive data.

Release note: None

Co-authored-by: Alex Lunev <alexl@cockroachlabs.com>
@knz
Copy link
Contributor Author

knz commented Jun 15, 2020

This has been addressed by #49457 and #48051

@knz knz closed this as completed Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-logging In and around the logging infrastructure. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knz