Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bulkio: parallelImporter can get stuck #49977

Closed
miretskiy opened this issue Jun 8, 2020 · 1 comment · Fixed by #49979
Closed

bulkio: parallelImporter can get stuck #49977

miretskiy opened this issue Jun 8, 2020 · 1 comment · Fixed by #49979
Assignees
@miretskiy
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@miretskiy
Copy link
Contributor

Parallel importer incorrectly handles the case when either the consumer returned an error,
or the import context itself was cancelled.
@miretskiy miretskiy self-assigned this Jun 8, 2020
@blathers-crl
Copy link

blathers-crl bot commented Jun 8, 2020

Hi @miretskiy, please add a C-ategory label to your issue. Check out the label system docs.

While you're here, please consider adding an A- label to help keep our repository tidy.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@miretskiy miretskiy added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Jun 8, 2020
@nvanbenschoten nvanbenschoten changed the title parallelImporter can get stuc bulkio: parallelImporter can get stuck Jun 8, 2020
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jun 8, 2020
importccl: Correctly handle errors and cancellations during import.
704a088 
Fixes cockroachdb#49977

Parallel importer could get stuck  due to a race between emitted
import batches and checking for context cancellation (either due to an
unforeseen error, or due to explicit context cancallation).

Fix the race condition, and add tests verifying correct behavior.

Release notes: bug fix -- correctly handle import cancellation and errors.
@miretskiy miretskiy mentioned this issue Jun 8, 2020
Merged
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jun 8, 2020
importccl: Correctly handle errors and cancellations during import.
9614189 
Fixes cockroachdb#49977

Parallel importer could get stuck  due to a race between emitted
import batches and checking for context cancellation (either due to an
unforeseen error, or due to explicit context cancallation).

Fix the race condition, and add tests verifying correct behavior.

Release notes: bug fix -- correctly handle import cancellation and errors.
craig bot pushed a commit that referenced this issue Jun 9, 2020
Merge #49979
f098913 
49979: importccl: Correctly handle errors and cancellations during import. r=miretskiy a=miretskiy

Fixes #49977

Parallel importer could get stuck  due to a race between emitted
import batches and checking for context cancellation (either due to an
unforeseen error, or due to explicit context cancallation).

Fix the race condition, and add tests verifying correct behavior.

Release notes (bug fix): correctly handle import cancellation and errors.

Co-authored-by: Yevgeniy Miretskiy <yevgeniy@cockroachlabs.com>
@craig craig bot closed this as completed in 39ba63e Jun 9, 2020
@miretskiy miretskiy mentioned this issue Jun 9, 2020
Merged
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jun 11, 2020
importccl: Correctly handle errors and cancellations during import.
7bf7849 
Fixes cockroachdb#49977

Parallel importer could get stuck  due to a race between emitted
import batches and checking for context cancellation (either due to an
unforeseen error, or due to explicit context cancallation).

Fix the race condition, and add tests verifying correct behavior.

Release notes (bug fix): correctly handle import cancellation and errors.
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jun 11, 2020
importccl: Correctly handle errors and cancellations during import.
e90ae53 
Fixes cockroachdb#49977

Parallel importer could get stuck  due to a race between emitted
import batches and checking for context cancellation (either due to an
unforeseen error, or due to explicit context cancallation).

Fix the race condition, and add tests verifying correct behavior.

Release notes (bug fix): correctly handle import cancellation and errors.
miretskiy pushed a commit to miretskiy/cockroach that referenced this issue Jun 11, 2020
importccl: Correctly handle errors and cancellations during import.
2982464 
Fixes cockroachdb#49977

Parallel importer could get stuck  due to a race between emitted
import batches and checking for context cancellation (either due to an
unforeseen error, or due to explicit context cancallation).

Fix the race condition, and add tests verifying correct behavior.

Release notes (bug fix): correctly handle import cancellation and errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miretskiy miretskiy

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

importccl: Correctly handle errors and cancellations during import. miretskiy/cockroach
1 participant
@miretskiy