Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: sqlsmith: to_json(): unexpected type *tree.DEnum for AsJSON #50524

Closed
cockroach-teamcity opened this issue Jun 23, 2020 · 0 comments · Fixed by #50547
Closed

roachtest: sqlsmith: to_json(): unexpected type *tree.DEnum for AsJSON #50524

cockroach-teamcity opened this issue Jun 23, 2020 · 0 comments · Fixed by #50547
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).sqlsmith/setup=seed/setting=no-mutations failed on master@6b9c32bf8d8553be6b0540f82ce18327b88262b5:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/sqlsmith/setup=seed/setting=no-mutations/run_1
	sqlsmith.go:169,sqlsmith.go:199,test_runner.go:753: error: pq: internal error: to_json(): unexpected type *tree.DEnum for AsJSON
		stmt:
		SELECT
			to_json(tab_5518._enum)::JSONB AS col_13872,
			tab_5516._int8 AS col_13873,
			tab_5516._date AS col_13874,
			tab_5517._uuid AS col_13875,
			tab_5517._interval AS col_13876,
			NULL AS col_13877,
			5782046592603117708:::INT8 AS col_13878,
			NULL AS col_13879,
			NULL AS col_13880
		FROM
			defaultdb.public.seed@seed__int8__float8__date_idx AS tab_5516,
			defaultdb.public.seed@seed__int8__float8__date_idx AS tab_5517
			JOIN defaultdb.public.seed@seed__int8__float8__date_idx AS tab_5518 ON
					(tab_5517._bool) = (tab_5518._bool) AND (tab_5517._decimal) = (tab_5518._decimal)
			JOIN defaultdb.public.seed AS tab_5519
				JOIN defaultdb.public.seed AS tab_5520 ON
						(tab_5519._int8) = (tab_5520._int8)
						AND (tab_5519._float8) = (tab_5520._float8)
						AND (tab_5519._date) = (tab_5520._date) ON (tab_5517._date) = (tab_5520._date)
		LIMIT
			20:::INT8;

More

Artifacts: /sqlsmith/setup=seed/setting=no-mutations
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Jun 23, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jun 23, 2020
@asubiotto asubiotto changed the title roachtest: sqlsmith/setup=seed/setting=no-mutations failed roachtest: sqlsmith: to_json(): unexpected type *tree.DEnum for AsJSON Jun 23, 2020
craig bot pushed a commit that referenced this issue Jun 23, 2020
49839: roachtest: Pin pgx to 4.6.0 r=apantel a=apantel

Release note: None

50255: ui,sql: add Vectorized info to statements page r=yuzefovich a=yuzefovich

This commit adds a box to Statements page that displays whether the
vectorized execution engine is used.

Release note (admin ui change): Statements page now contains information
about which execution engine is used (vectorized or not).


50286: sql: make error message for invalid id type reference better r=ajwerner a=rohany

Fixes #50276.

Release note (bug fix): Fix an internal error from being thrown when
referencing a type that does not exist by ID.

50402: kvserver: add a timeout to getChecksum to fix a flaky test r=lunevalex a=lunevalex

Fixes #48251

This change fixes an issue introduced in #49763. When a replica is being restored from a snapshot it does not compute checksums. This leads to a timeout on the whole check, resulting in a failure. A beter approach is to timeout the specific getChecksum request on a replica if we think it's not going to respond. The getChecksum() method will now wait a fraction of the whole deadline to see if a computeChecksum request is being computed and if one has not started in that time it will fail fast, instead of waiting the whole RPC deadline. We considered a number of alternative approaches, which either did not work or were unpalatable i.e. special casing LEARNER replicas in getChecksum, releasing getChecksum notify channel when we apply snapshots.

Release note : NONE

50411: gcjob: skip table if descriptor doesn't exist r=lucy-zhang a=lucy-zhang

Previously, the GC job would fail if a descriptor for a table to be
dropped did not exist. This can happen in cases where multiple GC jobs
are created for the same table, and one job deletes the table descriptor
first.

The existence of multiple GC jobs for the same table is itself
undesirable, but it's possible when some schema change job other than
the one created when dropping the table sees that the table is in the
dropped state and tries to drop the table anyway.

This PR mitigates the problem by skipping the table and marking it
internally as GC'ed if the descriptor doesn't exist.

Touches #50344.

Release note (bug fix): Fixes a bug affecting some `DROP DATABASE`
schema changes where multiple GC jobs are created, causing the GC job
for the database to fail. GC jobs will no longer fail upon failing to
find a table descriptor already deleted by a different GC job.

50502: sql: remove type annotations from computed cols in information_schema r=rafiss a=rohany

Fixes #50499.

No release note since this was introduced this release.

Release note: None

50547: tree: add a case for enums in AsJSON r=otan a=rohany

Fixes #50524.

This commit fixes an assertion failure by adding a case for enum types
in the `tree.AsJSON` function.

Release note: None

Co-authored-by: Adam Pantel <adam@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Rohan Yadav <rohany@alumni.cmu.edu>
Co-authored-by: Alex Lunev <alexl@cockroachlabs.com>
Co-authored-by: Lucy Zhang <lucy-zhang@users.noreply.github.com>
@craig craig bot closed this as completed in 56f1983 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants