Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: acceptance/bank/cluster-recovery failed #57342

Closed
cockroach-teamcity opened this issue Dec 2, 2020 · 8 comments · Fixed by #59762
Closed

roachtest: acceptance/bank/cluster-recovery failed #57342

cockroach-teamcity opened this issue Dec 2, 2020 · 8 comments · Fixed by #59762
Assignees
@andreimatei
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).acceptance/bank/cluster-recovery failed on master@3d0f281aa61c360311d9c96bf4e8f27ceaed28dc:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: artifacts/acceptance/bank/cluster-recovery/run_1
	bank.go:354,bank.go:427,acceptance.go:104,test_runner.go:760: after 30.0s: pq: query execution canceled due to statement timeout
		(1) attached stack trace
		  -- stack trace:
		  | main.(*bankClient).transferMoney
		  | 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/bank.go:74
		  | main.(*bankState).transferMoney
		  | 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/bank.go:158
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (2) after 30.0s
		Wraps: (3) pq: query execution canceled due to statement timeout
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *pq.Error
More

Artifacts: /acceptance/bank/cluster-recovery
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Dec 2, 2020
@nvanbenschoten nvanbenschoten removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Dec 3, 2020
@nvanbenschoten
Copy link
Member

I ran 250 iterations of this without a reproduction, so this doesn't look easy to repro.

@andreimatei
Copy link
Contributor

Happened also here on Nov 21st
https://teamcity.cockroachdb.com/viewLog.html?buildId=2462869&buildTypeId=Cockroach_UnitTests
https://teamcity.cockroachdb.com/viewLog.html?buildId=2462862&tab=buildResultsDiv&buildTypeId=Cockroach_UnitTests_Roachtest

@irfansharif
Copy link
Contributor

I've seen this fail on two of my PRs recently (last on in #57752). @adityamaru, I think you're test-infra oncall this week, lazily deferring to you for skipping+routing.

@cockroach-teamcity
Copy link
Member Author

(roachtest).acceptance/bank/cluster-recovery failed on master@beb8dd1a60e8b9a6885a1c091e3fcbea69a8cf88:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: artifacts/acceptance/bank/cluster-recovery/run_1
	test_runner.go:819: test timed out (10m0s)

	bank.go:350,bank.go:427,acceptance.go:104,test_runner.go:760: context canceled
More

Artifacts: /acceptance/bank/cluster-recovery
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).acceptance/bank/cluster-recovery failed on master@740d934ad87525bcd0500c2a15707f11115d7cff:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: artifacts/acceptance/bank/cluster-recovery/run_1
	bank.go:354,bank.go:427,acceptance.go:104,test_runner.go:760: after 31.0s: pq: query execution canceled due to statement timeout
		(1) attached stack trace
		  -- stack trace:
		  | main.(*bankClient).transferMoney
		  | 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/bank.go:74
		  | main.(*bankState).transferMoney
		  | 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/bank.go:158
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (2) after 31.0s
		Wraps: (3) pq: query execution canceled due to statement timeout
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *pq.Error
More

Artifacts: /acceptance/bank/cluster-recovery
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity
Copy link
Member Author

(roachtest).acceptance/bank/cluster-recovery failed on master@5fb71d88fb96a4ded0eb5414eb2eb88faaaf5895:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: artifacts/acceptance/bank/cluster-recovery/run_1
	bank.go:354,bank.go:427,acceptance.go:110,test_runner.go:760: after 31.0s: pq: query execution canceled due to statement timeout
		(1) attached stack trace
		  -- stack trace:
		  | main.(*bankClient).transferMoney
		  | 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/bank.go:74
		  | main.(*bankState).transferMoney
		  | 	/go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/bank.go:158
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1374
		Wraps: (2) after 31.0s
		Wraps: (3) pq: query execution canceled due to statement timeout
		Error types: (1) *withstack.withStack (2) *errutil.withPrefix (3) *pq.Error
More

Artifacts: /acceptance/bank/cluster-recovery
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@adityamaru
Copy link
Contributor

@aayushshah15 test-infra is going to skip this, assigning you as KV triage since it doesn't have an owner.

nkodali added a commit to nkodali/cockroach that referenced this issue Jan 8, 2021
@nkodali
roachtest: skip bank/cluster-recovery
9af173d 
Skips bank/cluster-recovery due to flakes.
See cockroachdb#57342.

Release note: none
@nkodali nkodali mentioned this issue Jan 8, 2021
Merged
craig bot pushed a commit that referenced this issue Jan 8, 2021
@knz @nkodali
Merge #57839 #58666
802b074 
57839: pgwire: migrate auth/conn logs to notable events r=otan,jordanlewis a=knz

Fixes  #56154 

Release note (backward-incompatible change): The connection and
authentication logging enabled by the cluster settings
`server.auth_log.sql_connections.enabled` and
`server.auth_log.sql_sessions.enabled` was previously using a text
format which was hard to parse and integrate with external monitoring
tools. This has been changed to use the standard notable event
mechanism, with standardized payloads. The output format is now
structured; see its reference documentation for details about
the supported event types and payloads.

58666: roachtest: skip bank/cluster-recovery r=adityamaru a=nkodali

Skips bank/cluster-recovery due to flakes.
See #57342.

Release note: none

Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
Co-authored-by: Namrata Kodali <namrata@cockroachlabs.com>
@tbg
Copy link
Member

tbg commented Jan 11, 2021

Could this be #57798 (comment)?

@tbg tbg assigned andreimatei and unassigned aayushshah15 Jan 11, 2021
@tbg tbg mentioned this issue Jan 11, 2021
Closed
@irfansharif irfansharif mentioned this issue Feb 3, 2021
Merged
craig bot pushed a commit that referenced this issue Feb 3, 2021
@irfansharif
Merge #59762
e57aa7f 
59762: roachtest: unskip acceptance/bank/cluster-recovery r=irfansharif a=irfansharif

Fixes #57342. This looks to have been the same thing as #57798, and was
fixed by #58722.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@craig craig bot closed this as completed in 860dde0 Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreimatei andreimatei

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

roachtest: unskip acceptance/bank/cluster-recovery irfansharif/cockroach
7 participants
@andreimatei @tbg @nvanbenschoten @irfansharif @aayushshah15 @adityamaru @cockroach-teamcity