sql: setting zone configs for non-materialized views should be forbidden

[postamar]

isn't it a bug that we even allow setting zone configs on (non-materialized) views in the first place? Is there any point to this?

Originally posted by @lucy-zhang in #57147 (comment)

Description: It's currently possible to run ALTER TABLE ... CONFIGURE ZONE statements on views. Considering that zone configs are meant to describe the physical layout of the data in a table, it doesn't make sense to me either that executing such a statement be possible on a non-physical table.

To reproduce:

demo@127.0.0.1:26257/movr> CREATE VIEW v AS SELECT 1; ALTER TABLE v CONFIGURE ZONE USING gc.ttlseconds = 100000;
CONFIGURE ZONE 1

I would instead expect an error like this:

ERROR: "v" is not a table
SQLSTATE: 42809

Looking at https://github.com/cockroachdb/cockroach/blob/master/pkg/sql/set_zone_config.go nothing is there to indicate that this behaviour is allowed for a good reason so I'm tentatively filing this as a bug despite having only a superficial understanding of things. If it turns out that it's not a bug then perhaps adding a comment to that effect in that source file might be helpful.

[naivcit]

Hi @rafiss can I take this one ?

[rafiss]

@naivcit Yes, thank you! We would appreciate your contribution.

to get started, look at pkg/sql/set_zone_config.go In the startExec function, after fetching the table descriptor with resolveTableForZone, you will likely need to check if table.IsPhysicalTable() and return an error message if it is not physical.

[jyz0309]

hi,@naivcit have you already started working on this? May I take it?

[naivcit]

Hey @jyz0309 yeah I am already working on this , sorry, will post a PR soon .