sql: tolerate non-SQL keys in AddContentionEvent #60669
Labels
A-sql-observability
Related to observability of the SQL layer
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Describe the problem
contentionRegistry.AddContentionEvent
currently assumes that all keys passed to it are SQL keys. This is not true, as evidenced by this test failure inacceptance/multitenant
:To Reproduce
Run acceptance/multitenant with a version of
(*DistSQLReceiver).Push
that does not throw away errors fromAddContentionEvent
.Expected behavior
I would expect the contention registry to handle such keys gracefully. It could either ignore them, but it's likely worth looking into whethercontention on non-SQL keys should be tracked (since the error above results from a SQL operation).
Environment:
The text was updated successfully, but these errors were encountered: