Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add test for concurrent region DDL operations #62813

Closed
arulajmani opened this issue Mar 30, 2021 · 0 comments · Fixed by #62826
Closed

sql: add test for concurrent region DDL operations #62813

arulajmani opened this issue Mar 30, 2021 · 0 comments · Fixed by #62826
Assignees
@arulajmani
Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.

Comments

@arulajmani
Copy link
Collaborator

Describe the problem

Currently, we only have a test for two concurrent region drops. We should extend this to include other combinations, such as add/drop, add/add etc.
@arulajmani arulajmani added the C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. label Mar 30, 2021
@arulajmani arulajmani self-assigned this Mar 30, 2021
@arulajmani arulajmani mentioned this issue Mar 30, 2021
Merged
arulajmani added a commit to arulajmani/cockroach that referenced this issue Mar 30, 2021
@arulajmani
sql: add tests for concurrent add/drop region operations
50092a7 
This patch generalizes the setup in what was previously
`TestConcurrentDropRegion` and extends it to all combinations of
add/drop region on a multi-region database. The only change is that
I've added a regional by row table into the test setup mixer, so as to
excercise the repartitioning semantics.

Previously, there was a limitation with concurrent add/drop regions
where both the operations were bound to fail in the repartitioning
phase. This limitation was fixed in cockroachdb#60620, but we never had a
regression test for it. Adding a regional by row table during the
test setup serves as one.

Closes cockroachdb#62813

Release note: None
craig bot pushed a commit that referenced this issue Apr 1, 2021
@aayushshah15 @tbg @arulajmani
Merge #61600 #62361 #62826
0966b27 
61600: kvserver: make the StoreRebalancer aware of non-voters r=aayushshah15 a=aayushshah15

This commit teaches the `StoreRebalancer` to rebalance non-voting
replicas.

Release justification: needed for non-voting replicas
Release note: None

62361: roachtest: attempt to handle VM overload under tpccbench r=irfansharif a=tbg

See #62039.

`tpccbench`, by design, pushes CRDB into overload territory. The test
harness handles nodes crashing or tpmc tanking well. However, it was
not prepared to handle the cloud VMs going unresponsive for ~minutes,
which is one common failure mode.

This commit tweaks the line search to be resilient to failures to
communicate with the cloud VM in the one place where it matters
(stopping the cluster at the beginning of a new search attempt).

The hope is that this will allow the search to run to completion,
even in the face of overload-imposed temporary VM outages. It is
not expected to do this reliably, but at least anecdotally most
VMs seem to come back a few minutes in.

Release note: None


62826: sql: add tests for concurrent add/drop region operations r=ajstorm a=arulajmani

This patch generalizes the setup in what was previously
`TestConcurrentDropRegion` and extends it to all combinations of
add/drop region on a multi-region database. The only change is that
I've added a regional by row table into the test setup mixer, so as to
excercise the repartitioning semantics.

Previously, there was a limitation with concurrent add/drop regions
where both the operations were bound to fail in the repartitioning
phase. This limitation was fixed in #60620, but we never had a
regression test for it. Adding a regional by row table during the
test setup serves as one.

Closes #62813

Release note: None

Co-authored-by: Aayush Shah <aayush.shah15@gmail.com>
Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Co-authored-by: arulajmani <arulajmani@gmail.com>
@craig craig bot closed this as completed in d83b25c Apr 2, 2021
arulajmani added a commit to arulajmani/cockroach that referenced this issue Apr 2, 2021
@arulajmani
sql: add tests for concurrent add/drop region operations
e2bc66a 
This patch generalizes the setup in what was previously
`TestConcurrentDropRegion` and extends it to all combinations of
add/drop region on a multi-region database. The only change is that
I've added a regional by row table into the test setup mixer, so as to
excercise the repartitioning semantics.

Previously, there was a limitation with concurrent add/drop regions
where both the operations were bound to fail in the repartitioning
phase. This limitation was fixed in cockroachdb#60620, but we never had a
regression test for it. Adding a regional by row table during the
test setup serves as one.

Closes cockroachdb#62813

Release note: None
@arulajmani arulajmani mentioned this issue Apr 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arulajmani arulajmani

Labels
C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add tests for concurrent add/drop region operations arulajmani/cockroach
1 participant
@arulajmani