-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: django failed #65691
roachtest: django failed #65691
Comments
@timgraham do you happen to know of anything that would cause these two tests to fail?
|
I can't think of anything offhand. Could you provide the traceback please? |
looks like any ALTER TYPE tests should not be run in parallel with other tests |
I can reproduce these failures with the CockroachDB master branch and I'd guess that the cause was backported to the release-21.1 branch after the 21.1.1 release as these test pass with that version. These tests don't run in parallel. This may be a bug in CockroachDB. I'll provide the exact steps to reproduce if needed. |
roachtest.django failed with artifacts on release-21.1 @ 15a6a314706eb15fb094feb6956600a9b864451b:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 587aaedda1a00fe03dd16317ec6da329f69a3ac9:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 1e2234a8449f6fe886387128dc5103866c4d244e:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
These tests don't fail every time. Both tests executes two Is this a new behavior since 21.1.1? It's incompatible with Django's migration framework which assumes that each query completes synchronously. |
It isn't exactly new behaviour but this type of schema change was disabled in a point release for 20.2. On the latest 20.2 version it would've disallowed the change and the command would fail. |
Right. I've managed to reproduce this with 21.1.0, so my guess that this is some regression since 21.1.1 isn't correct. It seems that the non-deterministic nature of the failure is the only reason we haven't seen it in other TeamCity builds. |
We can sort of wait for the schema change to finish by checking if the underlying JOB is done. Not sure what other options we have to check if the schema change is done. |
This is probably not just specific to tests to - the Django code does expect the schema change the finish synchronously whereas that's not what's happening. Certain inserts that are expected to work if the schema change is synchronous will fail. |
Correct. If feasible, perhaps you could add a |
roachtest.django failed with artifacts on release-21.1 @ 00b770d51383793d83c6c886357788dc211f7158:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ ac27d325ed08b76408e3bfdec3707c74d5a1c565:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ d8f279692a7c23013dacb774df231d51d9c6cd35:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
The skips are merged. I guess this ssue didn't auto-close because I don't have permissions to this repo. And it looks like #47137 is suitable as the follow up issue. |
We'll also need to update the crdb nightly test to use a newer version of django-cockroachdb (which means that we'd also have to publish a new version of django-cockroachdb). since the change was testing only, I don't know if publishing a new version is warranted.. |
Oh, I figured it used the master branch of django-cockroachdb. I agree it seems unnecessary to release a new package so I'll just unsubscribe from this issue to avoid the occasional pings. |
roachtest.django failed with artifacts on release-21.1 @ 62ea894aa0cd36435e43c7ce09ac5ebef91be78e:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 3da8bae2842269ad9ce72b22501293b2efcd3a71:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 10abf6e8bc246ec5c8b32ddc973f434595a46e5b:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 8cd2c9de5d5539e4837d6daa12a7b5c799554aca:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ af2c90b391faa0e0256b96269a0e3c2e29a0ca7b:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ e8671f5785c19039945459cc630c527d03f59d2e:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 4d113ce4e43672d60e0473831c02229583f18119:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 2d94ccf10cd0fefd113ec48261705f8810990cf3:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 6267da0f19b6cdc08e9fdd39899e35212694cb78:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ f60fbf28b0bb6110cf9870cc398ea169b81ff8f0:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 92e342b8f0032a5771d3e50932df4c6d7d85fe41:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ c38781390f0d07cf3d39d1af9ed01b4e370aaffa:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ ede1628bd625a07b3f966a36ea841009803fc8a9:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 5e8abbb1796889f75550fef774632b1bb2dfa87b:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ a866c9fe3948bcfcd028b94fc06afda7268fa985:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 21b5b06ea907f4adf0fef3318848e28f454138ea:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 32273aa49ce7006677bb1b4a0003b4ed8ac8b455:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 4bdd64a13faabc2024969f68d3bca17feacb5147:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ b7eaf3b47c220003b3d949af6d48d220c5f92db4:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 3ee6d71402938c32c266243cffd94c2c1d7bef9a:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ a59bb25a0c234e1752aa201fc8d6ccc4683c16b1:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ 03b83e02502e8876ecb366659156ab00f7431a51:
Reproduce
To reproduce, try: # From https://go.crdb.dev/p/roachstress, perhaps edited lightly.
caffeinate ./roachstress.sh django Same failure on other branches
|
roachtest.django failed with artifacts on release-21.1 @ b600d9c2283e19886406e658369e70b5c61a612f:
Reproduce
To reproduce, try:
# From https://go.crdb.dev/p/roachstress, perhaps edited lightly. caffeinate ./roachstress.sh django
Same failure on other branches
This test on roachdash | Improve this report!
The text was updated successfully, but these errors were encountered: