Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload trying to write to computed column for rand workload #66683

Closed
Lukens4242 opened this issue Jun 21, 2021 · 0 comments · Fixed by #66715
Closed

workload trying to write to computed column for rand workload #66683

Lukens4242 opened this issue Jun 21, 2021 · 0 comments · Fixed by #66715
Assignees
@mgartner
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-performance Perf of queries or internals. Solution not expected to change functional behavior.

Comments

@Lukens4242
Copy link
Contributor

Describe the problem

The workload binary, when used to run the rand workload, is trying to write to a computed column when executed.

To Reproduce

I init'd the rand workload and then tried to run it.

If possible, provide steps to reproduce the behavior:

create db cluster and log into node1

ubuntu@ip-10-12-25-52:~$ ./workload init  rand 'postgres://root@localhost:26257/?sslmode=disable'
ubuntu@ip-10-12-25-52:~$ ./workload run rand 'postgres://root@localhost:26257/?sslmode=disable'
I210621 19:01:49.985354 1 workload/cli/run.go:396  [-] 1  creating load generator...
Error: failed to initialize the load generator: pq: cannot write directly to computed column "col5577006791947779410_8"

Expected behavior
I expected to have the rand workload run w/o an error that prevents it from functioning.

Environment:

  • CockroachDB version 21.1.x
  • Server OS: ubuntu/aws
  • Client app: workload
@Lukens4242 Lukens4242 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-performance Perf of queries or internals. Solution not expected to change functional behavior. labels Jun 21, 2021
@rafiss rafiss mentioned this issue Jun 22, 2021
Merged
craig bot pushed a commit that referenced this issue Jun 22, 2021
@sai-roach @adityamaru @rafiss
Merge #63488 #66678 #66715
3255e7c 
63488: monitoring: renovate grafana dashboards r=kzh a=sai-roach

This PR adds in renovated grafana dashboards that aim for
feature parity with DB Console metrics page.

Dashboards:
- Overview
- Hardware
- Runtime
- SQL
- Storage
- Replication
- Distributed
- Queues
- Slow Requests
- Changefeeds

These dashboards can be previewed by following the instructions in
the monitoring [README.md](https://github.com/cockroachdb/cockroach/blob/master/monitoring/README.md) for spinning up a quick grafana instance.

Release note (ops change): The grafana dashboards have been updated to
more closely resemble DB console metrics.

66678: tracing: collector was incorrectly flattening recordings r=irfansharif,abarganier a=adityamaru

Previously, the trace collector was dialing up a node, visiting
all the root spans on the nodes inflight registry, and placing
`tracingpb.RecordedSpans` into a flat slice. This caused loss of
information about which spans belonged to a chain
rooted at a fixed root span. Such a chain is referred to as a
`tracing.Recording`. Every node can have multiple `tracing.Recording`s
with the same `trace_id`, and they each represent a traced remote
operation.

This change maintains the `tracing.Recording` grouping of spans
by getting the collector to return a `[]tracing.Recording` for each
node. The collectors' unit of iteration consequently becomes a
`tracing.Recording`. This makes more sense when you think about
how we want to consume these traces. Every `tracing.Recording` is
a new traced remote operation, and should be visualized as such in
Jaegar, JSON etc.

This change also augments the collector iterator to return the nodeID
of the node that the current `tracing.Recording` belongs too.

Informs: #64992

Release note: None

66715: workload: make rand workload aware of computed columns r=mgartner a=rafiss

fixes #66683

Release note: None

Co-authored-by: sai-roach <sai@cockroachlabs.com>
Co-authored-by: Aditya Maru <adityamaru@gmail.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig craig bot closed this as completed in 1bd0fe9 Jun 22, 2021
@rafiss rafiss mentioned this issue Jun 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgartner mgartner

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-performance Perf of queries or internals. Solution not expected to change functional behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload: make rand workload aware of computed columns rafiss/cockroach
2 participants
@mgartner @Lukens4242