Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a view in CRDB_INTERNAL which will transparently surface in-memory and persisted SQL stats #68193

Closed
Tracked by #64743
kevin-v-ngo opened this issue Jul 28, 2021 · 1 comment
Closed
Tracked by #64743

Create a view in CRDB_INTERNAL which will transparently surface in-memory and persisted SQL stats #68193

kevin-v-ngo opened this issue Jul 28, 2021 · 1 comment
Assignees
@Azhng
Labels
A-sql-cli-observability Issues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@kevin-v-ngo
Copy link

kevin-v-ngo commented Jul 28, 2021 •
edited
Loading

We are enabling persisted statistics in 21.2. We should allow developers to also easily query the most recent in-memory statistics as well.

Developers will now be able to query historical and the most recent statistics with a single cluster-level view.

Epic: CRDB-394
@kevin-v-ngo kevin-v-ngo added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-cli-observability Issues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc. labels Jul 28, 2021
@Azhng Azhng mentioned this issue Aug 6, 2021
Merged
Azhng added a commit to Azhng/cockroach that referenced this issue Aug 6, 2021
@Azhng
sql: support decode ExplainTreePlanNode from JSON format
fcbaa35 
Previously, we do not have support for decoding the
JSON-formatted ExplainTreePlanNode into the protobuf
format. This is required for us in order to implement
a crdb_internal virtual table that aggregates the cluster-wide
in-memory SQL stats and persisted SQL stats.

Related to cockroachdb#64743
Required for cockroachdb#68193

Release note: None
Azhng added a commit to Azhng/cockroach that referenced this issue Aug 10, 2021
@Azhng
sql: support decode ExplainTreePlanNode from JSON format
ecbf89a 
Previously, we do not have support for decoding the
JSON-formatted ExplainTreePlanNode into the protobuf
format. This is required for us in order to implement
a crdb_internal virtual table that aggregates the cluster-wide
in-memory SQL stats and persisted SQL stats.

Related to cockroachdb#64743
Required for cockroachdb#68193

Release note: None
craig bot pushed a commit that referenced this issue Aug 11, 2021
@Azhng
Merge #68555
26ebecb 
68555: sql: support decode ExplainTreePlanNode from JSON format r=Azhng a=Azhng

Previously, we do not have support for decoding the
JSON-formatted ExplainTreePlanNode into the protobuf
format. This is required for us in order to implement
a crdb_internal virtual table that aggregates the cluster-wide
in-memory SQL stats and persisted SQL stats.

Related to #64743
Required for #68193

Release note: None

Co-authored-by: Azhng <archer.xn@gmail.com>
@Azhng
Copy link
Contributor

Azhng commented Aug 23, 2021

@kevin-v-ngo can we close this issue now that we have crdb_internal.{statement,transaction}_statistics virtual tables ?

@Azhng Azhng mentioned this issue Aug 23, 2021
Closed
24 tasks
@maryliag maryliag closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Azhng Azhng

Labels
A-sql-cli-observability Issues related to surfacing SQL observability in SHOW, CRDB_INTERNAL, SYSTEM, etc. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maryliag @Azhng @kevin-v-ngo