Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: tenants can trace into KV #70407

Closed
tbg opened this issue Sep 20, 2021 · 1 comment
Closed

kvserver: tenants can trace into KV #70407

tbg opened this issue Sep 20, 2021 · 1 comment
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team

Comments

@tbg
Copy link
Member

tbg commented Sep 20, 2021

Describe the problem

When a tenant traces their SQL queries, they also get the KV portions of the traces. These are not suitably redacted and thus should not be handed to tenants.

To Reproduce

#70406

Expected behavior

Tenants don't get any unredacted KV-level traces. They need to get their ContentionEvents though (with an unredacted or at least unredacted-enough key).
@tbg tbg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Sep 20, 2021
@blathers-crl blathers-crl bot added the T-kv KV Team label Sep 20, 2021
tbg added a commit to tbg/cockroach that referenced this issue Sep 20, 2021
@tbg
kvserver: strip verbose logs and tags for tenant traces
aa5b884 
Touches cockroachdb#70407.

It does not exactly fix it, as the approach here is a blocklist on our
main KV endpoint, whereas we really need an allowlist that applies to
all possible current and future endpoints.

Release note: None
@tbg
Copy link
Member Author

tbg commented Oct 27, 2021

This is now "fixed" and the remainder of the work is owned by the obs-inf team. On 21.2, tenant redaction was reverted and we instead drop the verbose logs entirely (and obs-inf owns bringing them back), on master we redact tenant traces but we have a perf regression (which is also owned by obs-inf). Here are the issues:

#58610 (comment)

#71694

@tbg tbg closed this as completed Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-kv KV Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tbg