ui,jobs: improve UI for cancel-requested, pause-requested, and revert-failed statuses on the jobs page
#71963
Labels
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Comments
jocrl
added
the
C-enhancement
|
Perhaps the default value should also be |
|
This should also be easier to develop on after the jobs page storybook story is added by #68179 |
|
I think the color updates you suggested for those statuses make sense. CC @vy-ton for any thoughts on these additional statuses |
|
These are real statuses in our infrastructure. My concern is whether we should display the jobs infra details to the user. @ajwerner any thoughts here? An idea could be to translate the set of backend statuses:
|
|
Discussed with @kevin-v-ngo, we want to keep the original statuses in case the translation causes more confusion. |
jocrl
added a commit
to jocrl/cockroach
that referenced
this issue
Mar 21, 2022
Addresses cockroachdb#71963 Previously the `cancel-requested`, `pause-requested`, and `revert-failed` had blue badges. Now, `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge. Release note (ui): Improved colors for status badges on the Jobs page. Three status on the Jobs page, `cancel-requested`, `pause-requested`, and `revert-failed`, previously had blue status badge colors that were uninformative of their meaning. This commit modifies the badge colors to reflect their meaning. Now `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge.
craig bot
pushed a commit
that referenced
this issue
Mar 22, 2022
78186: ui: improve UI for statuses on the jobs page r=jocrl a=jocrl Addresses #71963 Previously the `cancel-requested`, `pause-requested`, and `revert-failed` had blue badges.  Now, `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge.  Release note (ui): Improved colors for status badges on the Jobs page. Three status on the Jobs page, `cancel-requested`, `pause-requested`, and `revert-failed`, previously had blue status badge colors that were uninformative of their meaning. This commit modifies the badge colors to reflect their meaning. Now `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge. 78213: distsql: simple projection in experimental distsql planner panics r=msirek a=msirek Previously, selecting a given column from a table more than once could cause an `index out of range` panic when experimental_distsql_planning is set to always, for example: ``` CREATE TABLE kv (k INT PRIMARY KEY, v INT); INSERT INTO kv VALUES (1, 1), (2, 1), (3, 2); SET experimental_distsql_planning = always; SELECT v, k, k, v FROM kv; ``` This commit fixes the issue, which is due to incorrect mapping of selected columns to source column ordinals in `ConstructSimpleProject`. Release note: none 78243: backupccl: fix paper cut in latest files directory structure r=DarrylWong a=adityamaru Prior to this change, the LATEST files of a backup were written to `metadatalatest/` instead of `metadata/latest/`, this patch fixes that. Release note (bug fix): The LATEST file that points to the latest full backup in a collection was written to a directory path with the wrong structure. 78246: settings: retire kv.rangefeed.separated_intent_scan.enabled r=nvanbenschoten a=stevendanna This setting was added in a 21.2 backport #72315 but was never added to master: #71295 So from the perspective of someone who upgrades from 21.2, it is now a retired setting. Release justification: Low-risk bug fix Release note: None Co-authored-by: Josephine Lee <josephine@cockroachlabs.com> Co-authored-by: Mark Sirek <sirek@cockroachlabs.com> Co-authored-by: Aditya Maru <adityamaru@gmail.com> Co-authored-by: Steven Danna <danna@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Mar 28, 2022
Addresses #71963 Previously the `cancel-requested`, `pause-requested`, and `revert-failed` had blue badges. Now, `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge. Release note (ui): Improved colors for status badges on the Jobs page. Three status on the Jobs page, `cancel-requested`, `pause-requested`, and `revert-failed`, previously had blue status badge colors that were uninformative of their meaning. This commit modifies the badge colors to reflect their meaning. Now `cancel-requested` and `pause-requested` have gray badges and `revert-failed` has a red badge.
27 tasks
|
Fixed on #78186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently, the three statuses
cancel-requested,pause-requested, andrevert-failedare present in the back end code (https://github.com/cockroachdb/cockroach/blob/master/pkg/jobs/jobs.go#L198), but are not enumerated or treated specially in the front end (https://github.com/cockroachdb/cockroach/blob/master/pkg/ui/workspaces/db-console/src/views/jobs/jobStatusOptions.ts#L27). This causes these statuses to have a blue coloring for their badge, even though another color would better convey meaning.Describe the solution you'd like
Assuming that these statuses are real, I think the following would make sense?
cancel-requested: gray, same as cancelledpause-requested: gray, same as pausedrevert-failed: red, same as failed@Annebirzin @kevin-v-ngo
Jira issue: CRDB-10868
The text was updated successfully, but these errors were encountered: