Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver: TestReplicaCircuitBreaker_RangeFeed failed #76856

Closed
cockroach-teamcity opened this issue Feb 21, 2022 · 0 comments · Fixed by #78241
Closed

kv/kvserver: TestReplicaCircuitBreaker_RangeFeed failed #76856

cockroach-teamcity opened this issue Feb 21, 2022 · 0 comments · Fixed by #78241
Assignees
@tbg
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Feb 21, 2022 •
edited by cockroach-jira-scripts
Loading

kv/kvserver.TestReplicaCircuitBreaker_RangeFeed failed with artifacts on master @ 1a89121d67fa02d5c674766ea01d3c78455fd28b:

=== RUN   TestReplicaCircuitBreaker_RangeFeed
    test_log_scope.go:79: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReplicaCircuitBreaker_RangeFeed1722575909
    test_log_scope.go:80: use -show-logs to present logs inline
    client_replica_circuit_breaker_test.go:426: val:<key:"\372" value:<raw_bytes:"+\304\231\334\003hello" timestamp:<wall_time:1645451313227447418 > > prev_value:<timestamp:<> > > 
    replica_raft.go:1111: 1 RequestLease: using slow replication threshold 10ms
    replica_raft.go:1111: 1 Probe: using slow replication threshold 10ms
    client_replica_circuit_breaker_test.go:426: val:<key:"\372" value:<raw_bytes:"+\304\231\334\003hello" timestamp:<wall_time:1645451316137942899 > > prev_value:<timestamp:<> > > 
    client_replica_circuit_breaker_test.go:424: context deadline exceeded
    panic.go:661: -- test log scope end --
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestReplicaCircuitBreaker_RangeFeed1722575909
--- FAIL: TestReplicaCircuitBreaker_RangeFeed (50.80s)
Help

See also: How To Investigate a Go Test Failure (internal)
Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/kv

This test on roachdash | Improve this report!

Jira issue: CRDB-13304
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Feb 21, 2022
@blathers-crl blathers-crl bot added the T-kv KV Team label Feb 21, 2022
@erikgrinaker erikgrinaker added T-kv-replication and removed T-kv KV Team labels Feb 21, 2022
tbg added a commit to tbg/cockroach that referenced this issue Feb 24, 2022
@tbg
kv/kvserver: skip TestReplicaCircuitBreaker_RangeFeed
abbd05b 
Refs: cockroachdb#76856

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@tbg tbg mentioned this issue Feb 24, 2022
Merged
craig bot pushed a commit that referenced this issue Feb 25, 2022
@tbg
Merge #76971
0679c4c 
76971: kv/kvserver: skip TestReplicaCircuitBreaker_RangeFeed r=erikgrinaker a=tbg

Refs: #76856

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
maryliag pushed a commit to maryliag/cockroach that referenced this issue Feb 28, 2022
@tbg @maryliag
kv/kvserver: skip TestReplicaCircuitBreaker_RangeFeed
02c8d3c 
Refs: cockroachdb#76856

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@tbg @RajivTS
kv/kvserver: skip TestReplicaCircuitBreaker_RangeFeed
f0c7494 
Refs: cockroachdb#76856

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@tbg tbg mentioned this issue Mar 22, 2022
Merged
craig bot pushed a commit that referenced this issue Mar 28, 2022
@tbg @stevendanna
Merge #78241 #78312 #78422 #78490
f1c9743 
78241: kvserver: de-flake TestReplicaCircuitBreaker_RangeFeed r=erikgrinaker a=tbg

Fixes #76856.

Release note: None


78312: roachtest: improve debugging in transfer-leases r=erikgrinaker a=tbg

This test failed once and we weren't able to figure out why; having
the range status used by the test would've been useful.

Now this is saved and so the next time it fails we'll have more to
look at.

Closes #75438.

Release note: None


78422: roachtest: bump max wh for weekly tpccbench/nodes=12/cpu=16 r=srosenberg a=tbg

[It was maxing out, reliably.](https://roachperf.crdb.dev/?filter=&view=tpccbench%2Fnodes%3D12%2Fcpu%3D16&tab=gce)

Release note: None


78490: sqlproxyccl: exit pod-watcher-client on local context cancellation r=jaylim-crl,darinpp a=stevendanna

Previously, we used grpcutil.IsContextCanceled to detect when a
returned gRPC error was the result of a context cancellation.

I believe that the intent of this code was to detect when the _local_
context was cancelled, indicating that we are shutting down and thus
the watch-pods-client goroutine should exit.

This works because the gRPC library converts a local context.Canceled
error into a gRPC error. And, in gRPC before 1.45, if a server handler
returned context.Canceled, the returned gRPC error would have
status.Unknown, and thus not trigger this exit behavior.

As of gRPC 1.45, however, a context.Canceled error returned by a
server handler will also result in a gRPC error with status.Canceled [0],
meaning that the previous code will force the goroutine to exit in
response to a server-side error. From my reading of this code, it
appears we want to retry all server-side errors.

To account for this, we now only break out of the retry loop if our
local context is done.

Further, I've changed the test directory server implementation to
return an arguably more appropriate error when it is shutting down.

Fixes #78197

Release note: None

Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
Co-authored-by: Steven Danna <danna@cockroachlabs.com>
@craig craig bot closed this as completed in 87795e0 Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: de-flake TestReplicaCircuitBreaker_RangeFeed tbg/cockroach
3 participants
@erikgrinaker @tbg @cockroach-teamcity