Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bazel not updating docs.bzl #76905

Closed
jordanlewis opened this issue Feb 22, 2022 · 0 comments · Fixed by #76955
Closed

build: bazel not updating docs.bzl #76905

jordanlewis opened this issue Feb 22, 2022 · 0 comments · Fixed by #76955
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@jordanlewis
Copy link
Member

A patch I'm working on (#74006) is complaining that docs.bzl is out of date:

https://teamcity.cockroachdb.com/buildConfiguration/Cockroach_Ci_Tests_CheckGeneratedCode/4417069?showRootCauses=false&expandBuildChangesSection=true&expandBuildProblemsSection=true

But when I run dev generate bazel or dev generate docs or make bazel-generate or really anything else I can't seem to get it to regenerate that file. I assume there is some missing dependency tracking but I am not really sure.
@jordanlewis jordanlewis added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label Feb 22, 2022
@rickystewart rickystewart mentioned this issue Feb 23, 2022
Merged
craig bot pushed a commit that referenced this issue Feb 23, 2022
@rickystewart
Merge #76955
f2d7f41 
76955: bazel: refine `dev generate bazel` skip optimization r=irfansharif a=rickystewart

Without this stuff, a `dev generate bazel` without
`COCKROACH_BAZEL_FORCE_GENERATE=1` resulted in skipping `genbzl`
incorrectly.

Closes #76905.

Release note: None

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in 2a09abb Feb 24, 2022
maryliag pushed a commit to maryliag/cockroach that referenced this issue Feb 28, 2022
@rickystewart @maryliag
bazel: refine dev generate bazel skip optimization
4a6699d 
Without this stuff, a `dev generate bazel` without
`COCKROACH_BAZEL_FORCE_GENERATE=1` resulted in skipping `genbzl`
incorrectly.

Closes cockroachdb#76905.

Release note: None
RajivTS pushed a commit to RajivTS/cockroach that referenced this issue Mar 6, 2022
@rickystewart @RajivTS
bazel: refine dev generate bazel skip optimization
cf747cf 
Without this stuff, a `dev generate bazel` without
`COCKROACH_BAZEL_FORCE_GENERATE=1` resulted in skipping `genbzl`
incorrectly.

Closes cockroachdb#76905.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bazel: refine dev generate bazel skip optimization rickystewart/cockroach
1 participant
@jordanlewis