Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: TestPublicIndexTableSpans should exercise secondary tenant keyspans #82882

Closed
knz opened this issue Jun 14, 2022 · 1 comment · Fixed by #104820
Closed

backupccl: TestPublicIndexTableSpans should exercise secondary tenant keyspans #82882

knz opened this issue Jun 14, 2022 · 1 comment · Fixed by #104820
Assignees
@stevendanna
Labels
A-disaster-recovery A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-disaster-recovery

Comments

@knz
Copy link
Contributor

knz commented Jun 14, 2022 •
edited by exalate-issue-sync bot
Loading

Forked from #48123.

Describe the problem

Currently TestPublicIndexTableSpans (backupccl/backup_test.go) hardcodes to keys.TODOSQLCodec.

Expected behavior

The test should be modified to instead use two sub-tests, one using system tenant codec and one using a secondary tenant codec.

cc @stevendanna for triage

Epic CRDB-27613
Jira issue: CRDB-16709
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-disaster-recovery A-multitenancy Related to multi-tenancy T-disaster-recovery E-quick-win Likely to be a quick win for someone experienced. labels Jun 14, 2022
@blathers-crl
Copy link

blathers-crl bot commented Jun 14, 2022

cc @cockroachdb/bulk-io

@knz knz mentioned this issue Jun 14, 2022
Closed
8 tasks
@stevendanna stevendanna self-assigned this Jun 14, 2022
@yuzefovich yuzefovich mentioned this issue Jun 13, 2023
Merged
craig bot pushed a commit that referenced this issue Jun 14, 2023
@yuzefovich
Merge #104820 #104823 #104828
17fe468 
104820: backupccl: adjust a test to run for secondary tenant codec too r=yuzefovich a=yuzefovich

Fixes: #82882.

Release note: None

104823: row: remove leftover reference to TestingSQLCodec in a test r=yuzefovich a=yuzefovich

This was missed in #82890.

Addresses: #48123.
Epic: None

Release note: None

104828: base: remove OptionalNodeIDErr r=yuzefovich a=yuzefovich

This method was only used in one place where we need to get the SQL instance ID of the gateway. That place has been refactored to pass that ID explicitly from the DistSQLPlanner.

Addresses: #100826.
Epic: None

Release note: None

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
@craig craig bot closed this as completed in 1d3c777 Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevendanna stevendanna

Labels
A-disaster-recovery A-multitenancy Related to multi-tenancy C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. E-quick-win Likely to be a quick win for someone experienced. T-disaster-recovery
Projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: adjust a test to run for secondary tenant codec too yuzefovich/cockroach
2 participants
@knz @stevendanna