Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/logictest: TestLogic failed #83367

Closed
cockroach-teamcity opened this issue Jun 25, 2022 · 5 comments · Fixed by #83562
Closed

sql/logictest: TestLogic failed #83367

cockroach-teamcity opened this issue Jun 25, 2022 · 5 comments · Fixed by #83562
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Jun 25, 2022

sql/logictest.TestLogic failed with artifacts on master @ fc7ae339c3f85ad2a2b28643e47d7c20768fe237:

[05:10:55] DELETE FROM ab WHERE true;
INSERT INTO ab VALUES (1,1), (2,1), (3,3), (4, 7);
[05:10:55] SELECT b FROM ab GROUP BY a;
[05:10:55] 	-- OK;
[05:10:55] SELECT a+b, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a;
[05:10:55] 	-- OK;
[05:10:55] SELECT a, col1, b+col2, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a, col1;
[05:10:55] 	-- OK;
[05:10:55] SELECT a, b, count(*), count(col2) FROM ab LEFT JOIN tab ON b=col2 GROUP BY a;
[05:10:55] 	-- OK;
[05:10:55] SELECT a, b, count(*) FROM ab RIGHT JOIN tab ON b=col2 GROUP BY a;
[05:10:55] 	-- OK;
[05:10:55] CREATE TABLE xyz (
  x INT PRIMARY KEY,
  y INT,
  z INT,
  INDEX yz (y, z)
);
[05:10:55] rewrote:
CREATE TABLE xyz (x INT8 PRIMARY KEY, y INT8, z INT8, INDEX yz (y, z), FAMILY (z), FAMILY (x, y));


[05:10:55] INSERT INTO xyz VALUES (1, 2, 3), (2, 2, 7), (3, 2, 1), (4, 2, NULL), (5, 3, -1);
[05:10:55] SELECT min(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT min(z) FROM xyz WHERE y = 100 AND z IS NULL GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT max(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] SELECT max(z) FROM xyz WHERE y = 100 GROUP BY y;
[05:10:55] 	-- OK;
[05:10:55] DROP TABLE xyz;
[05:10:56] CREATE TABLE t44469_a (a INT, INDEX (a));
[05:10:56] CREATE TABLE t44469_b (b INT, INDEX (b));
[05:10:56] CREATE TABLE t44469_cd (c INT, d INT, INDEX (c, d));;
[05:10:56] rewrote:
CREATE TABLE t44469_cd (c INT8, d INT8, INDEX (c, d), FAMILY (c, d));


[05:10:56] SELECT DISTINCT ON (b) b
FROM t44469_a INNER LOOKUP JOIN t44469_b ON a = b INNER LOOKUP JOIN t44469_cd ON c = 1 AND d = a
ORDER BY b;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-17025

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jun 25, 2022
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Jun 25, 2022
@cockroach-teamcity
Copy link
Member Author

sql/logictest.TestLogic failed with artifacts on master @ b47dc374417fe4ba83570784040da5650238b30e:

[05:10:59] DELETE FROM ab WHERE true;
INSERT INTO ab VALUES (1,1), (2,1), (3,3), (4, 7);
[05:10:59] SELECT b FROM ab GROUP BY a;
[05:10:59] 	-- OK;
[05:10:59] SELECT a+b, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a;
[05:10:59] 	-- OK;
[05:10:59] SELECT a, col1, b+col2, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a, col1;
[05:10:59] 	-- OK;
[05:10:59] SELECT a, b, count(*), count(col2) FROM ab LEFT JOIN tab ON b=col2 GROUP BY a;
[05:10:59] 	-- OK;
[05:10:59] SELECT a, b, count(*) FROM ab RIGHT JOIN tab ON b=col2 GROUP BY a;
[05:10:59] 	-- OK;
[05:10:59] CREATE TABLE xyz (
  x INT PRIMARY KEY,
  y INT,
  z INT,
  INDEX yz (y, z)
);
[05:10:59] rewrote:
CREATE TABLE xyz (x INT8 PRIMARY KEY, y INT8, z INT8, INDEX yz (y, z), FAMILY (x, z, y));


[05:10:59] INSERT INTO xyz VALUES (1, 2, 3), (2, 2, 7), (3, 2, 1), (4, 2, NULL), (5, 3, -1);
[05:10:59] SELECT min(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT min(z) FROM xyz WHERE y = 100 AND z IS NULL GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT max(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] SELECT max(z) FROM xyz WHERE y = 100 GROUP BY y;
[05:10:59] 	-- OK;
[05:10:59] DROP TABLE xyz;
[05:10:59] CREATE TABLE t44469_a (a INT, INDEX (a));
[05:10:59] CREATE TABLE t44469_b (b INT, INDEX (b));
[05:10:59] CREATE TABLE t44469_cd (c INT, d INT, INDEX (c, d));;
[05:10:59] rewrote:
CREATE TABLE t44469_cd (c INT8, d INT8, INDEX (c, d), FAMILY (c, d));


[05:10:59] SELECT DISTINCT ON (b) b
FROM t44469_a INNER LOOKUP JOIN t44469_b ON a = b INNER LOOKUP JOIN t44469_cd ON c = 1 AND d = a
ORDER BY b;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/logictest.TestLogic failed with artifacts on master @ a611410e3babe97a14152381b89060e1bafa2e27:

[05:10:46] DELETE FROM ab WHERE true;
INSERT INTO ab VALUES (1,1), (2,1), (3,3), (4, 7);
[05:10:46] SELECT b FROM ab GROUP BY a;
[05:10:46] 	-- OK;
[05:10:46] SELECT a+b, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a;
[05:10:46] 	-- OK;
[05:10:46] SELECT a, col1, b+col2, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a, col1;
[05:10:46] 	-- OK;
[05:10:46] SELECT a, b, count(*), count(col2) FROM ab LEFT JOIN tab ON b=col2 GROUP BY a;
[05:10:46] 	-- OK;
[05:10:46] SELECT a, b, count(*) FROM ab RIGHT JOIN tab ON b=col2 GROUP BY a;
[05:10:46] 	-- OK;
[05:10:46] CREATE TABLE xyz (
  x INT PRIMARY KEY,
  y INT,
  z INT,
  INDEX yz (y, z)
);
[05:10:46] rewrote:
CREATE TABLE xyz (x INT8 PRIMARY KEY, y INT8, z INT8, INDEX yz (y, z), FAMILY (x), FAMILY (z), FAMILY (y));


[05:10:46] INSERT INTO xyz VALUES (1, 2, 3), (2, 2, 7), (3, 2, 1), (4, 2, NULL), (5, 3, -1);
[05:10:46] SELECT min(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT min(z) FROM xyz WHERE y = 100 AND z IS NULL GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT max(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:10:46] 	-- OK;
[05:10:46] SELECT max(z) FROM xyz WHERE y = 100 GROUP BY y;
[05:10:47] 	-- OK;
[05:10:47] DROP TABLE xyz;
[05:10:47] CREATE TABLE t44469_a (a INT, INDEX (a));
[05:10:47] CREATE TABLE t44469_b (b INT, INDEX (b));
[05:10:47] CREATE TABLE t44469_cd (c INT, d INT, INDEX (c, d));;
[05:10:47] rewrote:
CREATE TABLE t44469_cd (c INT8, d INT8, INDEX (c, d), FAMILY (d, c));


[05:10:47] SELECT DISTINCT ON (b) b
FROM t44469_a INNER LOOKUP JOIN t44469_b ON a = b INNER LOOKUP JOIN t44469_cd ON c = 1 AND d = a
ORDER BY b;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@yuzefovich
Copy link
Member

This fails only on SQL Logic Test High VModule Nightly (Bazel) CI config with

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x10127eb]

goroutine 1033 [running]:
github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).closeWrapper(0xc003604000, {0x63e29f0, 0xc0005b6280}, {0x5637dc0, 0x858d520})
	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1053 +0x3d4
github.com/cockroachdb/cockroach/pkg/sql.(*Server).ServeConn.func1()
	github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:755 +0x6b
panic({0x5637dc0, 0x858d520})
	GOROOT/src/runtime/panic.go:1047 +0x266
github.com/cockroachdb/cockroach/pkg/sql/colexecerror.CatchVectorizedRuntimeError.func1()
	github.com/cockroachdb/cockroach/pkg/sql/colexecerror/error.go:58 +0x50c
panic({0x5637dc0, 0x858d520})
	GOROOT/src/runtime/panic.go:1047 +0x266
github.com/cockroachdb/cockroach/pkg/util/log.getIdentificationPayload({0x0, 0x0})
	github.com/cockroachdb/cockroach/pkg/util/log/server_ident.go:57 +0x6b
github.com/cockroachdb/cockroach/pkg/util/log.makeEntry({0x0, 0x0}, _, _, _)
	github.com/cockroachdb/cockroach/pkg/util/log/log_entry.go:193 +0x88
github.com/cockroachdb/cockroach/pkg/util/log.makeUnstructuredEntry({_, _}, _, _, _, _, {_, _}, {0xc001312b20, 0x3, ...})
	github.com/cockroachdb/cockroach/pkg/util/log/log_entry.go:232 +0xc5
github.com/cockroachdb/cockroach/pkg/util/log.logfDepthInternal({0x0, 0x0}, 0x3, 0x1, 0x0, 0x0, {0x5c72c6a, 0x2a}, {0xc001312b20, 0x3, ...})
	github.com/cockroachdb/cockroach/pkg/util/log/channels.go:98 +0x5dc
github.com/cockroachdb/cockroach/pkg/util/log.logfDepth({0x0, 0x0}, 0x2, 0x1, 0x0, {0x5c72c6a, 0x2a}, {0xc001312b20, 0x3, 0x3})
	github.com/cockroachdb/cockroach/pkg/util/log/channels.go:39 +0x9d
github.com/cockroachdb/cockroach/pkg/util/log.InfofDepth({0x0, 0x0}, 0x1, {0x5c72c6a, 0x2a}, {0xc001312b20, 0x3, 0x3})
	github.com/cockroachdb/cockroach/bazel-out/k8-dbg/bin/pkg/util/log/log_channels_generated.go:332 +0x87
github.com/cockroachdb/cockroach/pkg/util/mon.(*BytesMonitor).Start(0xc0048f7680, {0x0, 0x0}, 0xc0048f6a80, {0x0, 0x0, 0x0, 0x0, 0x0})
	github.com/cockroachdb/cockroach/pkg/util/mon/bytes_usage.go:365 +0x3e5
github.com/cockroachdb/cockroach/pkg/sql/execinfra.NewMonitor({0x0, 0x0}, 0xc0048f6a80, {0x5befab1, 0xd})
	github.com/cockroachdb/cockroach/pkg/sql/execinfra/processorsbase.go:957 +0x85
github.com/cockroachdb/cockroach/pkg/sql/rowexec.newJoinReader(0xc004ea72c0, 0x1, 0xc0040b2000, {0x6408878, 0xc004ea7e00}, 0xc00355daf8, {0x0, 0x0}, 0x0)
	github.com/cockroachdb/cockroach/pkg/sql/rowexec/joinreader.go:478 +0x2032
github.com/cockroachdb/cockroach/pkg/sql/rowexec.NewProcessor({0x63e29f0, 0xc004adc680}, 0xc004ea72c0, 0x1, 0xc00355d9f0, 0xc00355daf8, {0xc003a654f0, 0x1, 0x1}, {0xc003a65510, ...}, ...)
...

@yuzefovich yuzefovich self-assigned this Jun 28, 2022
@cockroach-teamcity
Copy link
Member Author

sql/logictest.TestLogic failed with artifacts on master @ 7f8fef4c3f24ec2b6f9a3db1eb38756da68b3d5a:

[05:11:46] DELETE FROM ab WHERE true;
INSERT INTO ab VALUES (1,1), (2,1), (3,3), (4, 7);
[05:11:46] SELECT b FROM ab GROUP BY a;
[05:11:46] 	-- OK;
[05:11:46] SELECT a+b, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a;
[05:11:46] 	-- OK;
[05:11:46] SELECT a, col1, b+col2, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a, col1;
[05:11:46] 	-- OK;
[05:11:46] SELECT a, b, count(*), count(col2) FROM ab LEFT JOIN tab ON b=col2 GROUP BY a;
[05:11:46] 	-- OK;
[05:11:46] SELECT a, b, count(*) FROM ab RIGHT JOIN tab ON b=col2 GROUP BY a;
[05:11:46] 	-- OK;
[05:11:46] CREATE TABLE xyz (
  x INT PRIMARY KEY,
  y INT,
  z INT,
  INDEX yz (y, z)
);
[05:11:46] rewrote:
CREATE TABLE xyz (x INT8 PRIMARY KEY, y INT8, z INT8, INDEX yz (y, z), FAMILY (z, y, x));


[05:11:46] INSERT INTO xyz VALUES (1, 2, 3), (2, 2, 7), (3, 2, 1), (4, 2, NULL), (5, 3, -1);
[05:11:46] SELECT min(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT min(z) FROM xyz WHERE y = 100 AND z IS NULL GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT max(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] SELECT max(z) FROM xyz WHERE y = 100 GROUP BY y;
[05:11:46] 	-- OK;
[05:11:46] DROP TABLE xyz;
[05:11:46] CREATE TABLE t44469_a (a INT, INDEX (a));
[05:11:46] CREATE TABLE t44469_b (b INT, INDEX (b));
[05:11:46] CREATE TABLE t44469_cd (c INT, d INT, INDEX (c, d));;
[05:11:46] rewrote:
CREATE TABLE t44469_cd (c INT8, d INT8, INDEX (c, d), FAMILY (d, c));


[05:11:46] SELECT DISTINCT ON (b) b
FROM t44469_a INNER LOOKUP JOIN t44469_b ON a = b INNER LOOKUP JOIN t44469_cd ON c = 1 AND d = a
ORDER BY b;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/logictest.TestLogic failed with artifacts on master @ ac11a55499120ffd33016feebc47b4ed43a21007:

[05:11:07] DELETE FROM ab WHERE true;
INSERT INTO ab VALUES (1,1), (2,1), (3,3), (4, 7);
[05:11:07] SELECT b FROM ab GROUP BY a;
[05:11:07] 	-- OK;
[05:11:07] SELECT a+b, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a;
[05:11:07] 	-- OK;
[05:11:07] SELECT a, col1, b+col2, count(*) FROM ab JOIN tab ON b=col2 GROUP BY a, col1;
[05:11:07] 	-- OK;
[05:11:07] SELECT a, b, count(*), count(col2) FROM ab LEFT JOIN tab ON b=col2 GROUP BY a;
[05:11:07] 	-- OK;
[05:11:07] SELECT a, b, count(*) FROM ab RIGHT JOIN tab ON b=col2 GROUP BY a;
[05:11:07] 	-- OK;
[05:11:07] CREATE TABLE xyz (
  x INT PRIMARY KEY,
  y INT,
  z INT,
  INDEX yz (y, z)
);
[05:11:07] rewrote:
CREATE TABLE xyz (x INT8 PRIMARY KEY, y INT8, z INT8, INDEX yz (y, z), FAMILY (z, x, y));


[05:11:07] INSERT INTO xyz VALUES (1, 2, 3), (2, 2, 7), (3, 2, 1), (4, 2, NULL), (5, 3, -1);
[05:11:07] SELECT min(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT min(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT min(z) FROM xyz WHERE y = 100 AND z IS NULL GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT max(z) FROM xyz WHERE y = 2 GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NOT NULL GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT max(z) FROM xyz WHERE y = 2 AND z IS NULL GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] SELECT max(z) FROM xyz WHERE y = 100 GROUP BY y;
[05:11:07] 	-- OK;
[05:11:07] DROP TABLE xyz;
[05:11:07] CREATE TABLE t44469_a (a INT, INDEX (a));
[05:11:07] CREATE TABLE t44469_b (b INT, INDEX (b));
[05:11:07] CREATE TABLE t44469_cd (c INT, d INT, INDEX (c, d));;
[05:11:07] rewrote:
CREATE TABLE t44469_cd (c INT8, d INT8, INDEX (c, d), FAMILY (c, d));


[05:11:07] SELECT DISTINCT ON (b) b
FROM t44469_a INNER LOOKUP JOIN t44469_b ON a = b INNER LOOKUP JOIN t44469_cd ON c = 1 AND d = a
ORDER BY b;
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

craig bot pushed a commit that referenced this issue Jun 29, 2022
83386: batcheval: handle MVCC range tombstones in `RefreshRange` r=aliher1911 a=erikgrinaker

This patch add handling of MVCC range tombstones in `RefreshRange`, by
erroring on them as a committed value.

Resolves #83383.

Release note: None

83562: rowexec: fix recent bug of using nil context r=yuzefovich a=yuzefovich

In e7e724e we moved the creation of
a monitor for the streamer's disk usage into the constructor of the join
reader but forgot to update the context used during that operation. The
thing is that the context on the processors is only set in `Start`
meaning it is `nil` in the construct of the processor. This commit fixes
the issue.

Fixes: #83367

Release note: None

Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
@craig craig bot closed this as completed in e461d15 Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants