Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: add help messages for UDF statements in sql.y #87425

Closed
chengxiong-ruan opened this issue Sep 6, 2022 · 1 comment · Fixed by #88493
Closed

sql: add help messages for UDF statements in sql.y #87425

chengxiong-ruan opened this issue Sep 6, 2022 · 1 comment · Fixed by #88493
Assignees
@chengxiong-ruan
Labels
A-sql-routine UDFs and Stored Procedures branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@chengxiong-ruan
Copy link
Contributor

chengxiong-ruan commented Sep 6, 2022 •
edited by exalate-issue-sync bot
Loading

Add proper help messages for UDF statements in sql.y file. Also need to link online docs at the end of each help message when available.

Jira issue: CRDB-19343
@chengxiong-ruan chengxiong-ruan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-schema-deprecated Use T-sql-foundations instead A-sql-routine UDFs and Stored Procedures labels Sep 6, 2022
@chengxiong-ruan chengxiong-ruan self-assigned this Sep 6, 2022
@blathers-crl
Copy link

blathers-crl bot commented Sep 6, 2022

Hi @chengxiong-ruan, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@chengxiong-ruan chengxiong-ruan added the branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 label Sep 6, 2022
@chengxiong-ruan chengxiong-ruan mentioned this issue Sep 22, 2022
Merged
chengxiong-ruan added a commit to chengxiong-ruan/cockroach that referenced this issue Sep 23, 2022
@chengxiong-ruan
sql: add grammar help text for udf statements
b8d72f0 
Backport resolves cockroachdb#87425

Release note: None
Release justification: necessary but low risk user experience change
craig bot pushed a commit that referenced this issue Sep 23, 2022
@chengxiong-ruan @rafiss
Merge #88493 #88629
dc8897e 
88493: sql: add grammar help text for udf statements r=chengxiong-ruan a=chengxiong-ruan

Backport resolves #87425

Release note: None
Release justification: necessary but low risk user experience change

88629: sql: fix missed error handling when parsing internal query r=ZhouXing19 a=rafiss

refs #87673
refs #87673

Release note: None

Co-authored-by: Chengxiong Ruan <chengxiongruan@gmail.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@craig craig bot closed this as completed in 9d0173c Sep 23, 2022
blathers-crl bot pushed a commit that referenced this issue Sep 23, 2022
@chengxiong-ruan
sql: add grammar help text for udf statements
55d47bc 
Backport resolves #87425

Release note: None
Release justification: necessary but low risk user experience change
@blathers-crl blathers-crl bot mentioned this issue Sep 23, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot reopened this Oct 24, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chengxiong-ruan chengxiong-ruan

Labels
A-sql-routine UDFs and Stored Procedures branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: add grammar help text for udf statements chengxiong-ruan/cockroach
1 participant
@chengxiong-ruan