Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvserver: revert recent reproposal changes #97973

Closed
5 tasks done
tbg opened this issue Mar 3, 2023 · 2 comments · Fixed by #98481
Closed
5 tasks done

kvserver: revert recent reproposal changes #97973

tbg opened this issue Mar 3, 2023 · 2 comments · Fixed by #98481
Assignees
@tbg
Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker

Comments

@tbg
Copy link
Member

tbg commented Mar 3, 2023 •
edited
Loading

We recently made changes to the proposal pipeline. These surfaced that there is much more complexity than previously recognized. We have a plan to remedy this but it's out of scope for 23.1. Instead we want to remove any refactors that have happened so far and for 23.2 execute on the plan instead.

This list should be exhaustive but we need to double-check. The 23.1 code should closely match the 22.2 code before this issue can be closed.

Jira issue: CRDB-24997
Epic: CRDB-25287
@tbg tbg added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker T-kv-replication labels Mar 3, 2023
@tbg tbg self-assigned this Mar 3, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 3, 2023

cc @cockroachdb/replication

@blathers-crl

This comment was marked as resolved.

Sign in to view
@erikgrinaker erikgrinaker added branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 labels Mar 3, 2023
@tbg tbg mentioned this issue Mar 13, 2023
Merged
tbg added a commit to tbg/cockroach that referenced this issue Mar 13, 2023
@tbg
Revert "kvserver: improve reproposal assertions and documentation"
939f955 
Reverts cockroachdb#97973.

This reverts commit 866d58a.
@craig craig bot closed this as completed in 3b326c3 Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
branch-master Failures and bugs on the master branch. branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kvserver: revert recent changes to reproposals tbg/cockroach
2 participants
@erikgrinaker @tbg