Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: work around go loader and stale packages #9983

Closed
tbg opened this issue Oct 14, 2016 · 2 comments
Closed

build: work around go loader and stale packages #9983

tbg opened this issue Oct 14, 2016 · 2 comments
Assignees
@dt

Comments

@tbg
Copy link
Member

tbg commented Oct 14, 2016

All packages need to be installed before we can run (some) of the checks and
code generators reliably. More precisely, anything that using x/tools/go/loader
is fragile (this includes stringer, vet and others).

The blocking issue is golang/go#14120; see
golang/go#10249 for some more concrete discussion on
stringer and golang/go#16086 for vet.
@tbg tbg mentioned this issue Oct 14, 2016
Merged
@tbg
Copy link
Member Author

tbg commented Oct 14, 2016

See #9981 (comment) for ideas and some preliminary discussion (including suggestions to fold all of these checks and generations into make check).

@dt
Copy link
Member

dt commented Oct 31, 2016

we ended up walking this back to always just run -i ./... since so many tools needed it.

@dt dt closed this as completed Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dt dt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dt @tbg