ci: install all packages first

[tbg]

All packages need to be installed before we can run (some) of the checks and
code generators reliably. More precisely, anything that using x/tools/go/loader
is fragile (this includes stringer, vet and others).

The blocking issue is golang/go#14120; see
golang/go#10249 for some more concrete discussion on
stringer and golang/go#16086 for vet.

---

This change is

[petermattis]

Doesn't this imply we should add gotestdashi as a dependency of make check?

[tbg]

It does imply that, but we'd still need it here for stability (no reason we wouldn't reorder make check and go generate). I like @dt's idea though.

[dt]

Could we do these steps inside style_check.go, wrapped in a if !testing.Short(), so they could be skipped easily when only running pure text manipulation linter?

[tbg]

@dt That's a good idea. Would you mind doing that? You can poach this PR for the commentary or I can merge it, your call (or whoever is up for putting in the elbow grease).

[tbg]

One problem with the diff check though is that it mutates the repo state (running go generate).
I think that's generally awkward. What if it fails? You've just messed with a bunch of files. There could be uncommited files even before you run make check. We certainly shouldn't expect that to be run from a clean repo.

[dt]

@tschottdorf I probably won't do that today, so don't wait for me -- if you want to merge for now and file an issue to follow up later?

[tbg]

SGTM, will do once LGTSO

[tamird]

Thanks for tracking down the upstream issues. I agree with @petermattis that this should be hooked into the relevant stuff globally, and not just in TC.

[tbg]

Yes, but how do you hook it into go generate ./...? We'd have to put it one line before each stringer invocation and hope for the best?

[tbg]

Generate processes packages in the order given on the command line,
one at a time. If the command line lists .go files, they are treated
as a single package. Within a package, generate processes the
source files in a package in file name order, one at a time. Within
a source file, generate runs generators in the order they appear
in the file, one at a time.

Hmm, we could make a file that shows up first and make that run go build -i ./...? But then it'll still fail if you just generate a subpkg explicitly.

[tbg]

Filed #9983 for the remainder of the discussion. I'll merge this as per @dt's suggestion.