kvserver: expose LSM snapshot storage-engine timeseries metrics #100518
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Expose two new storage-engine metrics that provide visibility into LSM snapshots. These two new metrics record cumulative count and size of obsolete keys written to sstables during flushes and compactions. Epic: None Release note (ops change): Expose two new timeseries metrics `storage.compactions.keys.pinned.count` and `storage.compactions.keys.pinned.bytes` providing some observability into the volume of keys preserved by open LSM snapshots. Informs cockroachdb/pebble#1204.
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @jbowens)
|
TFTR! bors r=RaduBerinde |
|
bors r=RaduBerinde |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6847cfd to blathers/backport-release-23.1-100518: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Expose two new storage-engine metrics that provide visibility into LSM snapshots. These two new metrics record cumulative count and size of obsolete keys written to sstables during flushes and compactions.
Epic: None
Release note (ops change): Expose two new timeseries metrics
storage.compactions.keys.pinned.countandstorage.compactions.keys.pinned.bytesproviding some observability into the volume of keys preserved by open LSM snapshots.Informs cockroachdb/pebble#1204.