Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contextutil: teach TimeoutError to redact only the operation name #100741

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

andreimatei
Copy link
Contributor

Before this patch, the whole message of TimeoutError was redacted in logs. Now, only the operation name is.

Release note: None
Epic: None

Before this patch, the whole message of TimeoutError was redacted in
logs. Now, only the operation name is.

Release note: None
Epic: None
@andreimatei andreimatei requested review from knz and a team April 5, 2023 18:19
@blathers-crl
Copy link

blathers-crl bot commented Apr 5, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@knz knz added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 6, 2023
@andreimatei
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 6, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants