upgrademanager: audit tests that use MakeTestingClusterSettingsWithVersions

[rafiss]

informs #100552

Release note: None

[cockroach-teamcity]

This change is 

[rafiss]

bors r+

[rafiss]

bors r+

[craig]

Already running a review

[craig]

Build failed:

• Bazel Essential CI (Cockroach)

[rafiss]

flake fixed by #100895

bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error setting reviewers, but backport branch blathers/backport-release-23.1-100873 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100899/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

[nvanbenschoten]

In #100900, we saw TestConcurrentMigrationAttempts (touched here) hit a timeout. There's no history of this test failing, so some flakiness may have been uncovered by these changes.