tree: fix decimal formatting for 0 with exponents <= -7 #102220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously did not match PG in outputting 0 with exponents <= -7 over the wire. This is because we try to match the "GDA" spec, but PG doesn't follow that for 0 (it should display a solitary 0 if it did). This 0E-7 formatting still shows up when using the Cockroach CLI tool. I verified it works correctly when connecting via the PG tool. Release note (bug fix): Fixed a bug where 0s with exponents <= 7 in NUMERIC types would display in a different format compared with PostgreSQL (before: 0E-7 vs after/PG: 0.0000000) when sent over the wire.
|
This change is |
|
this doesn't fix it, seems like some cache issue? the first invocation makes it "0E+16", but the second makes it "0.00000...". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously did not match PG in outputting 0 with exponents <= -7 over the wire. This is because we try to match the "GDA" spec, but PG doesn't follow that for 0 (it should display a solitary 0 if it did).
This 0E-7 formatting still shows up when using the Cockroach CLI tool. I verified it works correctly when connecting via the PG tool.
Release note (bug fix): Fixed a bug where 0s with exponents <= 7 in NUMERIC types would display in a different format compared with PostgreSQL (before: 0E-7 vs after/PG: 0.0000000) when sent over the wire.
Resolves #102217