sql: Add information_schema.views

[szpony]

Add information_schema.views.
Pls refer to #8675

---

This change is

[CLAassistant]

All committers have signed the CLA.

[a-robinson]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

pkg/sql/information_schema.go, line 434 at r1 (raw file):

                  parser.NewDString(db.Name),         // table_schema
                  parser.NewDString(table.Name),      // table_name
                  parser.NewDString(table.ViewQuery), // view_definition

You may want to include a disclaimer/TODO about the view query printed here (as I've done in #10276) about how this won't properly insert column aliases into the query

---

Comments from Reviewable

[szpony]

Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

pkg/sql/information_schema.go, line 434 at r1 (raw file):

Previously, a-robinson (Alex Robinson) wrote…

You may want to include a disclaimer/TODO about the view query printed here (as I've done in #10276) about how this won't properly insert column aliases into the query

done. Thanks

---

Comments from Reviewable

[nvanbenschoten]

other than the small nits. Thanks @mtMabo!

---

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pkg/sql/information_schema.go, line 434 at r1 (raw file):

Previously, mtMabo (MaBo) wrote…

done. Thanks

`s/TODO/TODO(a-robinson)/` so that this doesnt get lost.

---

pkg/sql/testdata/information_schema, line 675 at r2 (raw file):

query TTTTTBBBBB colnames
SELECT * FROM information_schema.views WHERE TABLE_NAME='v_xyz'; 

Let's split this into two queries so it's a little more readable.

---

Comments from Reviewable

[szpony]

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pkg/sql/testdata/information_schema, line 675 at r2 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

Let's split this into two queries so it's a little more readable.

What do you mean "split this into two queries so it's a little more readable" ?

---

Comments from Reviewable

[nvanbenschoten]

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pkg/sql/testdata/information_schema, line 675 at r2 (raw file):

Previously, mtMabo (MaBo) wrote…

What do you mean "split this into two queries so it's a little more readable" ?

Instead of `SELECT *`, select from 5 columns each in two queries.

---

Comments from Reviewable

[szpony]

Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pkg/sql/information_schema.go, line 434 at r1 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

s/TODO/TODO(a-robinson)/ so that this doesnt get lost.

Done.

---

pkg/sql/testdata/information_schema, line 675 at r2 (raw file):

Previously, nvanbenschoten (Nathan VanBenschoten) wrote…

Instead of SELECT *, select from 5 columns each in two queries.

Done. Thanks

---

Comments from Reviewable